Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8E86D200CED for ; Fri, 4 Aug 2017 03:29:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8D21716CE1D; Fri, 4 Aug 2017 01:29:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D47F816CE1E for ; Fri, 4 Aug 2017 03:29:06 +0200 (CEST) Received: (qmail 57013 invoked by uid 500); 4 Aug 2017 01:29:05 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 56911 invoked by uid 99); 4 Aug 2017 01:29:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 01:29:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4CF5F18041D for ; Fri, 4 Aug 2017 01:29:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id m8lIYGgpbsqO for ; Fri, 4 Aug 2017 01:29:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 039955F523 for ; Fri, 4 Aug 2017 01:29:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E4800E0E1C for ; Fri, 4 Aug 2017 01:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C1FBC2465E for ; Fri, 4 Aug 2017 01:29:00 +0000 (UTC) Date: Fri, 4 Aug 2017 01:29:00 +0000 (UTC) From: "Mitth'raw'nuruodo (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4837) StringConverter adds a decimal place to integers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 04 Aug 2017 01:29:07 -0000 [ https://issues.apache.org/jira/browse/WW-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113771#comment-16113771 ] Mitth'raw'nuruodo commented on WW-4837: --------------------------------------- [~lukaszlenart] Why did WW-3171 include enforcing a minimum number of decimal places? If that's not essential, dropping it ought to fix this. > StringConverter adds a decimal place to integers > ------------------------------------------------ > > Key: WW-4837 > URL: https://issues.apache.org/jira/browse/WW-4837 > Project: Struts 2 > Issue Type: Bug > Components: Core > Affects Versions: 2.5.12 > Reporter: Mitth'raw'nuruodo > > Commit 229afea64e77c2dba9eec62b2c339e9fc92c9ec7 caused all inputs recognisable as numbers to be formatted with at least one decimal place. This includes all integers, which is frequently undesirable, particularly if they were meant to be, eg: > - identifiers, not for arithmetic; > - strictly validated against an XML schema that does not allow for floating-point numbers; > - subject to length limitations; > - etc > This apparently occurs because all inputs that look like numbers, regardless of format, are of type {{BigDecimal}} by the time they reach the {{StringConverter}}. > For our applications, this is a blocker; is it working differently for others? We don't have any special handling of input types. -- This message was sent by Atlassian JIRA (v6.4.14#64029)