Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 028F7200CD7 for ; Tue, 1 Aug 2017 11:58:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F3388166C69; Tue, 1 Aug 2017 09:58:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1EE48166C65 for ; Tue, 1 Aug 2017 11:58:06 +0200 (CEST) Received: (qmail 24547 invoked by uid 500); 1 Aug 2017 09:58:06 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 24537 invoked by uid 99); 1 Aug 2017 09:58:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2017 09:58:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9B8101A20C8 for ; Tue, 1 Aug 2017 09:58:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id tSOyd3U0dgVL for ; Tue, 1 Aug 2017 09:58:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3316660EB4 for ; Tue, 1 Aug 2017 09:58:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0E98BE0D28 for ; Tue, 1 Aug 2017 09:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 640AD2464E for ; Tue, 1 Aug 2017 09:58:00 +0000 (UTC) Date: Tue, 1 Aug 2017 09:58:00 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (WW-4829) Set a global resource bundle in class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 01 Aug 2017 09:58:08 -0000 [ https://issues.apache.org/jira/browse/WW-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108655#comment-16108655 ] Lukasz Lenart edited comment on WW-4829 at 8/1/17 9:57 AM: ----------------------------------------------------------- I would do it like this {code:java} public class MyTextProviderFactory implements TextProviderFactory { protected LocaleProviderFactory localeProviderFactory; protected LocalizedTextProvider localizedTextProvider; @Inject public StrutsTextProviderFactory(LocaleProviderFactory localeProviderFactory, LocalizedTextProvider localizedTextProvider) { this.localeProviderFactory = localeProviderFactory; this.localizedTextProvider = localizedTextProvider; this.localizedTextProvider.addDefaultResourceBundle("myBundle"); } @Override public TextProvider createInstance(Class clazz) { TextProvider instance = getTextProvider(clazz); if (instance instanceof ResourceBundleTextProvider) { ((ResourceBundleTextProvider) instance).setClazz(clazz); ((ResourceBundleTextProvider) instance).setLocaleProvider(localeProviderFactory.createLocaleProvider()); } return instance; } @Override public TextProvider createInstance(ResourceBundle bundle) { TextProvider instance = getTextProvider(bundle); if (instance instanceof ResourceBundleTextProvider) { ((ResourceBundleTextProvider) instance).setBundle(bundle); ((ResourceBundleTextProvider) instance).setLocaleProvider(localeProviderFactory.createLocaleProvider()); } return instance; } protected TextProvider getTextProvider(Class clazz) { return new TextProviderSupport(clazz, localeProviderFactory.createLocaleProvider(), localizedTextProvider); } protected TextProvider getTextProvider(ResourceBundle bundle) { return new TextProviderSupport(bundle, localeProviderFactory.createLocaleProvider(), localizedTextProvider); } } {code} was (Author: lukaszlenart): I would do it like this {code:java} public class StrutsTextProviderFactory implements TextProviderFactory { protected LocaleProviderFactory localeProviderFactory; protected LocalizedTextProvider localizedTextProvider; @Inject public StrutsTextProviderFactory(LocaleProviderFactory localeProviderFactory, LocalizedTextProvider localizedTextProvider) { this.localeProviderFactory = localeProviderFactory; this.localizedTextProvider = localizedTextProvider; this.localizedTextProvider.addDefaultResourceBundle("myBundle"); } @Override public TextProvider createInstance(Class clazz) { TextProvider instance = getTextProvider(clazz); if (instance instanceof ResourceBundleTextProvider) { ((ResourceBundleTextProvider) instance).setClazz(clazz); ((ResourceBundleTextProvider) instance).setLocaleProvider(localeProviderFactory.createLocaleProvider()); } return instance; } @Override public TextProvider createInstance(ResourceBundle bundle) { TextProvider instance = getTextProvider(bundle); if (instance instanceof ResourceBundleTextProvider) { ((ResourceBundleTextProvider) instance).setBundle(bundle); ((ResourceBundleTextProvider) instance).setLocaleProvider(localeProviderFactory.createLocaleProvider()); } return instance; } protected TextProvider getTextProvider(Class clazz) { return new TextProviderSupport(clazz, localeProviderFactory.createLocaleProvider(), localizedTextProvider); } protected TextProvider getTextProvider(ResourceBundle bundle) { return new TextProviderSupport(bundle, localeProviderFactory.createLocaleProvider(), localizedTextProvider); } } {code} > Set a global resource bundle in class > -------------------------------------- > > Key: WW-4829 > URL: https://issues.apache.org/jira/browse/WW-4829 > Project: Struts 2 > Issue Type: Bug > Components: Core > Affects Versions: 2.5.12 > Reporter: Alireza Fattahi > Fix For: 2.5.13 > > > In struts 2.5.12 the *LocalizedTextUtil* is removed. > We used to `*LocalizedTextUtil.addDefaultResourceBundle*` in our classes to add resource bundles. This was mentioned in https://struts.apache.org/docs/how-do-i-set-a-global-resource-bundle.html > Can you please let me know how this can be done with this change ?! -- This message was sent by Atlassian JIRA (v6.4.14#64029)