struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mitth'raw'nuruodo (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (WW-4837) StringConverter adds a decimal place to integers
Date Mon, 07 Aug 2017 22:30:01 GMT

    [ https://issues.apache.org/jira/browse/WW-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117439#comment-16117439
] 

Mitth'raw'nuruodo edited comment on WW-4837 at 8/7/17 10:29 PM:
----------------------------------------------------------------

No, we don't specify the type.
{code}
<@s.textfield theme="forces"
    name="gst"
    value=35
    label="GST"
    size=6
    id="gst"
/>
{code}

I've taken a look at Freemarker documentation, but didn't find anything to help sort this
out (It's possible that Freemarker is converting all literal numbers to BigDecimal, which
would be an unfortunate combination with WW-3171, but understandable). Anyway, we didn't really
need our attributes to be treated as any sort of number, so quoting them is working fine.


was (Author: thrawnca):
No, we don't specify the type.
{code}
<@s.textfield theme="forces"
    name="gst"
    value=35
    label="GST"
    size=6
    id="gst"
/>
{code}

> StringConverter adds a decimal place to integers
> ------------------------------------------------
>
>                 Key: WW-4837
>                 URL: https://issues.apache.org/jira/browse/WW-4837
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.12
>            Reporter: Mitth'raw'nuruodo
>             Fix For: 2.5.13
>
>
> Commit 229afea64e77c2dba9eec62b2c339e9fc92c9ec7 caused all inputs recognisable as numbers
to be formatted with at least one decimal place. This includes all integers, which is frequently
undesirable, particularly if they were meant to be, eg:
> - identifiers, not for arithmetic;
> - strictly validated against an XML schema that does not allow for floating-point numbers;
> - subject to length limitations;
> - etc
> This apparently occurs because all inputs that look like numbers, regardless of format,
are of type {{BigDecimal}} by the time they reach the {{StringConverter}}.
> For our applications, this is a blocker; is it working differently for others? We don't
have any special handling of input types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message