struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4834) Improve RegEx used to validate URLs
Date Thu, 03 Aug 2017 16:36:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113047#comment-16113047
] 

ASF GitHub Bot commented on WW-4834:
------------------------------------

Github user sdutry commented on the issue:

    https://github.com/apache/struts/pull/157
  
    > After the commit above, any IP with 3 digits in the last octet will not pass validation
    
    You are right, i forgot the grouping (meaning the or statements mean something completely
different), i'll fix this ASAP
    
    > The expression did not seem to work at all until I escaped the slashes, changing
/ to \/
    I don't see why this would be. I am not aware that a "/" is a special sign inside a java
string or java RegEx. Or is it because this same regex is used in javascript regex validation
(where the '/' sign does mean something). I'll change it back ASAP too


> Improve RegEx used to validate URLs
> -----------------------------------
>
>                 Key: WW-4834
>                 URL: https://issues.apache.org/jira/browse/WW-4834
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core, XML Validators
>    Affects Versions: 2.3.33, 2.5.12
>            Reporter: Lukasz Lenart
>             Fix For: 2.3.34, 2.5.13
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message