struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4834) Improve RegEx used to validate URLs
Date Tue, 01 Aug 2017 15:51:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109137#comment-16109137
] 

ASF GitHub Bot commented on WW-4834:
------------------------------------

GitHub user sdutry opened a pull request:

    https://github.com/apache/struts/pull/156

    WW-4834 Improve RegEx used to validate URLs

    changed the regex according to https://github.com/apache/struts/commit/8df5a897f61f3ef45c36fdd9275e66669ae4516c#commitcomment-23414493
    
    Can anyone tell me if the optional `#` on line 54 is needed?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sdutry/struts WW-4834

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 9d47af6ffa355977b5acc713e6d1f25fac260a28
Author: Stefaan Dutry <stefaan.dutry@gmail.com>
Date:   2017-08-01T15:33:53Z

    WW-4834 Improve RegEx used to validate URLs

----


> Improve RegEx used to validate URLs
> -----------------------------------
>
>                 Key: WW-4834
>                 URL: https://issues.apache.org/jira/browse/WW-4834
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core, XML Validators
>    Affects Versions: 2.3.33, 2.5.12
>            Reporter: Lukasz Lenart
>             Fix For: 2.3.34, 2.5.13
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message