Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 029BA200CD5 for ; Sun, 30 Jul 2017 11:47:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F3818162F99; Sun, 30 Jul 2017 09:47:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 44D5F162F13 for ; Sun, 30 Jul 2017 11:47:06 +0200 (CEST) Received: (qmail 57169 invoked by uid 500); 30 Jul 2017 09:47:05 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 57159 invoked by uid 99); 30 Jul 2017 09:47:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Jul 2017 09:47:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D61E9C0042 for ; Sun, 30 Jul 2017 09:47:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.502 X-Spam-Level: X-Spam-Status: No, score=-99.502 tagged_above=-999 required=6.31 tests=[KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Iir59aAV4nzl for ; Sun, 30 Jul 2017 09:47:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BC75E5FC1C for ; Sun, 30 Jul 2017 09:47:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 590A1E0D54 for ; Sun, 30 Jul 2017 09:47:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 46B5824655 for ; Sun, 30 Jul 2017 09:47:00 +0000 (UTC) Date: Sun, 30 Jul 2017 09:47:00 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4830) Override TextProvider doesnot work in struts 2.5.12 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 30 Jul 2017 09:47:07 -0000 [ https://issues.apache.org/jira/browse/WW-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106408#comment-16106408 ] Lukasz Lenart commented on WW-4830: ----------------------------------- You should use {{TextProviderFactory}} instead, the {{DefaultTextProvider}} is only used internally as a fallback solution a which soon should also be dropped. Here you have an example how to implement your custom factory https://github.com/apache/struts-examples/blob/master/text-provider/ Here is some more details about that https://struts.apache.org/docs/localization.html#Localization-CustomTextProviderandTextProviderFactory > Override TextProvider doesnot work in struts 2.5.12 > --------------------------------------------------- > > Key: WW-4830 > URL: https://issues.apache.org/jira/browse/WW-4830 > Project: Struts 2 > Issue Type: Bug > Components: Core > Affects Versions: 2.5.12 > Reporter: Alireza Fattahi > Fix For: 2.5.13 > > > In struts 2.3 , to override the TextProvider we used below > {code:xml} > > > {code} > And make CustomTextProvider > {code} > public class CustomTextProvider extends DefaultTextProvider{ > public String getText(String key, String defaultValue, List args) { > String text = super.getText(key, defaultValue, args); > //Do something with the text > //and return it > } > //other getText methods can be override too > } > {code} > This seems not to be worked at Struts 2.15.2. > To make some test, I remove my bean from* strust.xml* and put some break points in *DefaultTextProvider *the *getText *of this class is not called, however I find that the *TextProviderSupport **getText *method is called. > Should we override other classes ?! -- This message was sent by Atlassian JIRA (v6.4.14#64029)