Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 15367200C78 for ; Thu, 18 May 2017 09:36:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 13D87160BC4; Thu, 18 May 2017 07:36:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 57E7B160BB0 for ; Thu, 18 May 2017 09:36:09 +0200 (CEST) Received: (qmail 92837 invoked by uid 500); 18 May 2017 07:36:08 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 92827 invoked by uid 99); 18 May 2017 07:36:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 May 2017 07:36:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BD291CCF31 for ; Thu, 18 May 2017 07:36:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id v2-l4iNSjg1t for ; Thu, 18 May 2017 07:36:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8AB8F5FBC5 for ; Thu, 18 May 2017 07:36:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 40F43E0D4D for ; Thu, 18 May 2017 07:36:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 456A1263AB for ; Thu, 18 May 2017 07:36:04 +0000 (UTC) Date: Thu, 18 May 2017 07:36:04 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4762) DefaultLocalizedTextProvider refactoring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 18 May 2017 07:36:10 -0000 [ https://issues.apache.org/jira/browse/WW-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015346#comment-16015346 ] ASF GitHub Bot commented on WW-4762: ------------------------------------ Github user gregh3269 commented on the issue: https://github.com/apache/struts/pull/137 I can re-test it when merged. > DefaultLocalizedTextProvider refactoring > ---------------------------------------- > > Key: WW-4762 > URL: https://issues.apache.org/jira/browse/WW-4762 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Greg Huber > Assignee: Lukasz Lenart > Priority: Minor > Fix For: 2.5.next > > > Now that DefaultLocalizedTextProvider is a bean, would it be possible to refactor the code to allow an override so we can change the default behavior on the package searching for the resource.properties files. Currently is does an extensive search up the class interfaces first which on busy screens slows things down and is an unnecessary overhead. > ie As I have migrated from struts1 my main UI resources are in the default ApplicationResources.properties file and are shared across struts ui classes in various packages. I would not want to duplicate the .properties entries for maintenance etc. > I would then want to search the default ApplicationResources.properties first and then package class (for validation messages) and then possibly up the interfaces (which would not make sense for me as I do not use this logic). > Discussion related to this > http://markmail.org/message/v2oc6c35swfwzwid -- This message was sent by Atlassian JIRA (v6.3.15#6346)