Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 13382200C63 for ; Thu, 11 May 2017 17:28:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 11D0B160BCA; Thu, 11 May 2017 15:28:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 609DB160BB2 for ; Thu, 11 May 2017 17:28:08 +0200 (CEST) Received: (qmail 75037 invoked by uid 500); 11 May 2017 15:28:07 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 75027 invoked by uid 99); 11 May 2017 15:28:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 15:28:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 27D7DCEBF6 for ; Thu, 11 May 2017 15:28:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SqaQwC4Ug2hN for ; Thu, 11 May 2017 15:28:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E9FDB5FC8E for ; Thu, 11 May 2017 15:28:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78564E0641 for ; Thu, 11 May 2017 15:28:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2DFED21E0C for ; Thu, 11 May 2017 15:28:04 +0000 (UTC) Date: Thu, 11 May 2017 15:28:04 +0000 (UTC) From: "Greg Huber (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References:

Subject: [jira] [Comment Edited] (WW-4762) DefaultLocalizedTextProvider refactoring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 11 May 2017 15:28:09 -0000 [ https://issues.apache.org/jira/browse/WW-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006623#comment-16006623 ] Greg Huber edited comment on WW-4762 at 5/11/17 3:27 PM: --------------------------------------------------------- ok, I copied the tiles plugin also (and now the tiles error is gone and it works). When i add ```xml ``` I get this (core jar) SEVERE: Servlet.service() for servlet [default] in context with path [] threw exception java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Unable to load bean com.opensymphony.xwork2.LocalizedTextProvider (default-only) - [unknown location] ##### To make it work : ```xml ``` and then update my : struts.custom.i18n.resources=ApplicationResources to include EventAdd, EventEdit, FolderAdd, FolderEdit, etc there are probably about 40 files as they are validator message.properties etc ie struts.custom.i18n.resources=ApplicationResources, EventAdd, EventEdit, FolderAdd, FolderEdit was (Author: gregh99): ok, I copied the tiles plugin also (and now the tiles error is gone and it works). When i add ```xml ``` I get this (core jar) SEVERE: Servlet.service() for servlet [default] in context with path [] threw exception java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Unable to load bean com.opensymphony.xwork2.LocalizedTextProvider (default-only) - [unknown location] ##### To make it work : ```xml ``` and then update my : struts.custom.i18n.resources=ApplicationResources to include EventAdd, EventEdit, FolderAdd, FolderEdit, etc there are probably about 100+ files as they are validator message.properties etc ie struts.custom.i18n.resources=ApplicationResources, EventAdd, EventEdit, FolderAdd, FolderEdit > DefaultLocalizedTextProvider refactoring > ---------------------------------------- > > Key: WW-4762 > URL: https://issues.apache.org/jira/browse/WW-4762 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Greg Huber > Assignee: Lukasz Lenart > Priority: Minor > Fix For: 2.5.next > > > Now that DefaultLocalizedTextProvider is a bean, would it be possible to refactor the code to allow an override so we can change the default behavior on the package searching for the resource.properties files. Currently is does an extensive search up the class interfaces first which on busy screens slows things down and is an unnecessary overhead. > ie As I have migrated from struts1 my main UI resources are in the default ApplicationResources.properties file and are shared across struts ui classes in various packages. I would not want to duplicate the .properties entries for maintenance etc. > I would then want to search the default ApplicationResources.properties first and then package class (for validation messages) and then possibly up the interfaces (which would not make sense for me as I do not use this logic). > Discussion related to this > http://markmail.org/message/v2oc6c35swfwzwid -- This message was sent by Atlassian JIRA (v6.3.15#6346)