struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4762) DefaultLocalizedTextProvider refactoring
Date Thu, 18 May 2017 08:35:10 GMT

    [ https://issues.apache.org/jira/browse/WW-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015429#comment-16015429
] 

Hudson commented on WW-4762:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-JDK7-master #631 (See [https://builds.apache.org/job/Struts-JDK7-master/631/])
WW-4762 Drops unused code (lukaszlenart: rev 45d1a491311a82f6b2404d839e7e18269a26192f)
* (edit) core/src/main/java/org/apache/struts2/util/StrutsTestCaseHelper.java
WW-4762 Drops unused imports (lukaszlenart: rev 3ffc9b8450845d7a90a623607e3b4bb05888e2f9)
* (edit) core/src/test/java/org/apache/struts2/config/PropertiesConfigurationProviderTest.java
* (edit) core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
* (edit) core/src/main/java/com/opensymphony/xwork2/DefaultTextProvider.java
WW-4762 Uses Struts prefix for the main implementation (lukaszlenart: rev 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84)
* (add) core/src/test/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProviderTest.java
* (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
* (delete) core/src/test/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProviderTest.java
* (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
* (edit) core/src/main/resources/struts-default.xml
* (delete) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
* (add) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
WW-4762 Extracts base abstract class (lukaszlenart: rev 2e23d7a07ea4313136dc38b8de2451b04c882064)
* (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
* (add) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
WW-4762 Introduces default provider which only uses default bundles (lukaszlenart: rev bb19a6209886795b76385e48fd86424c144ee029)
* (add) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
WW-4762 Moves common method up (lukaszlenart: rev 7360b5e1956f415866c189d7adda861456d4d069)
* (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
WW-4762 Extracts common method (lukaszlenart: rev fd168c423f70383a6240cba9809a87b661ef39de)
* (edit) core/src/main/java/com/opensymphony/xwork2/util/DefaultLocalizedTextProvider.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/StrutsLocalizedTextProvider.java
* (edit) core/src/main/java/com/opensymphony/xwork2/util/AbstractLocalizedTextProvider.java
WW-4762 Defines default-only bean (lukaszlenart: rev 4604333649a0060421c07cd5520c8285ca0c135f)
* (edit) core/src/main/resources/struts-default.xml


> DefaultLocalizedTextProvider refactoring
> ----------------------------------------
>
>                 Key: WW-4762
>                 URL: https://issues.apache.org/jira/browse/WW-4762
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Greg Huber
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.5.next
>
>
> Now that DefaultLocalizedTextProvider is a bean, would it be possible to refactor the
code to allow an override so we can change the default behavior on the package searching for
the resource.properties files.  Currently is does an extensive search up the class interfaces
first which on busy screens slows things down and is an unnecessary overhead. 
> ie As I have migrated from struts1 my main UI resources are in the default ApplicationResources.properties
file and are shared across struts ui classes in various packages. I would not want to duplicate
the .properties entries for maintenance etc.
> I would then want to search the default ApplicationResources.properties first and then
package class (for validation messages) and then possibly up the interfaces (which would not
make sense for me as I do not use this logic).
> Discussion related to this
> http://markmail.org/message/v2oc6c35swfwzwid



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message