struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4762) DefaultLocalizedTextProvider refactoring
Date Wed, 10 May 2017 11:55:04 GMT

    [ https://issues.apache.org/jira/browse/WW-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004541#comment-16004541
] 

ASF GitHub Bot commented on WW-4762:
------------------------------------

GitHub user lukaszlenart opened a pull request:

    https://github.com/apache/struts/pull/137

    WW-4762: Default provider

    Implements a default text provider which only operates on defined default bundles and
those provided via `struts.custom.i18n.resources`
    
    Implements [WW-4762](https://issues.apache.org/jira/browse/WW-4762)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukaszlenart/struts default-provider

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 45d1a491311a82f6b2404d839e7e18269a26192f
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-04-26T09:55:49Z

    WW-4762 Drops unused code

commit 3ffc9b8450845d7a90a623607e3b4bb05888e2f9
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-04-26T09:56:09Z

    WW-4762 Drops unused imports

commit 8bf77a1d19d31dbc8574dcbf958c3da2a4724c84
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-04-26T09:56:48Z

    WW-4762 Uses Struts prefix for the main implementation

commit 2e23d7a07ea4313136dc38b8de2451b04c882064
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-04-26T10:24:57Z

    WW-4762 Extracts base abstract class

commit bb19a6209886795b76385e48fd86424c144ee029
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-04-26T18:28:11Z

    WW-4762 Introduces default provider which only uses default bundles

----


> DefaultLocalizedTextProvider refactoring
> ----------------------------------------
>
>                 Key: WW-4762
>                 URL: https://issues.apache.org/jira/browse/WW-4762
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Greg Huber
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.5.next
>
>
> Now that DefaultLocalizedTextProvider is a bean, would it be possible to refactor the
code to allow an override so we can change the default behavior on the package searching for
the resource.properties files.  Currently is does an extensive search up the class interfaces
first which on busy screens slows things down and is an unnecessary overhead. 
> ie As I have migrated from struts1 my main UI resources are in the default ApplicationResources.properties
file and are shared across struts ui classes in various packages. I would not want to duplicate
the .properties entries for maintenance etc.
> I would then want to search the default ApplicationResources.properties first and then
package class (for validation messages) and then possibly up the interfaces (which would not
make sense for me as I do not use this logic).
> Discussion related to this
> http://markmail.org/message/v2oc6c35swfwzwid



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message