Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Sun, 26 Mar 2017 17:39:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13042758.1487035075000.125942.1490549981681@Atlassian.JIRA>
In-Reply-To: <JIRA.13042758.1487035075000@Atlassian.JIRA>
References: <JIRA.13042758.1487035075000@Atlassian.JIRA> <JIRA.13042758.1487035075444@jira-lw-us.apache.org>
Subject: [jira] [Commented] (WW-4744) AnnotationWorkflowInterceptor should
 supports non-public annotated methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 26 Mar 2017 17:39:51 -0000


    [ https://issues.apache.org/jira/browse/WW-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942358#comment-15942358 ] 

ASF GitHub Bot commented on WW-4744:
------------------------------------

Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/124
  
    So as I understand this is ready to be merged with a future notice to use Commons Lang 3.6 when available?


> AnnotationWorkflowInterceptor should supports non-public annotated methods
> --------------------------------------------------------------------------
>
>                 Key: WW-4744
>                 URL: https://issues.apache.org/jira/browse/WW-4744
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>            Reporter: zhouyanming
>             Fix For: 2.5.next
>
>
> {code:java}
> @Before
> protected String prepare(){
>     //TODO
>     return null;
> }
> {code}
> [https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationWorkflowInterceptor.java#L115]
> {code:java}
> List<Method> methods = new ArrayList<>(AnnotationUtils.getAnnotatedMethods(action.getClass(), Before.class));
> {code}
> [https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java#L123]
> {code:java}
> for (Method m : clazz.getMethods()) 
> {code}
> clazz.getMethods() only return public methods, so method "prepare" will be excluded, and protected modifier is a good practice for intercept method.We should improve AnnotationUtils.getAnnotatedMethods() to return all methods. Perhaps use an ConcurrentHashMap as cache is much better.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)