struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4757) Create LocaleProviderFactory and uses instead of LocaleProvider
Date Wed, 15 Mar 2017 08:21:41 GMT

    [ https://issues.apache.org/jira/browse/WW-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925725#comment-15925725
] 

ASF GitHub Bot commented on WW-4757:
------------------------------------

GitHub user lukaszlenart opened a pull request:

    https://github.com/apache/struts/pull/122

    WW-4757: LocaleProvider factory

    Replaces injectable `LocaleProvider` with `LocaleProviderFactory` to avoid problems with
multiple beans implementing the `LocaleProvider` interface.
    
    Implements [WW-4757](https://issues.apache.org/jira/browse/WW-4757)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukaszlenart/struts locale-factory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #122
    
----
commit b42b9f16c4598505e0b1cfef78e6639237b2d712
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-15T07:46:09Z

    Defines new interface for factory

commit 636821aa2dfc32a4531b6e65717c38625bb5b4cc
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-15T07:46:37Z

    Adds default implementation of the factory

commit 09be1b9b773f164d59114b0a73d3a4fde366b673
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-15T07:50:05Z

    Replaces LocaleProvider with LocaleProviderFactory

commit 3b738ad3ef01c434dbd673d5dca4659aa5779e7d
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-15T07:53:35Z

    Injects factory instead of the provider

commit 4b022bfbe5f575908e61d84de885ca171fcca7f3
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-15T08:11:31Z

    Replaces LocaleProvider with LocaleProviderFactory

commit f912dab8f3c77ef9667370c57cf8d35cf0cf4a32
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-15T08:18:24Z

    Fixes test

----


> Create LocaleProviderFactory and uses instead of LocaleProvider
> ---------------------------------------------------------------
>
>                 Key: WW-4757
>                 URL: https://issues.apache.org/jira/browse/WW-4757
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.5.10
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.5.next
>
>
> LocaleProvider is implemented by ActionSupport and this can introduce issue when injecting
dependency in long living objects like Interceptors. Using dedicated factory allows to distinguish
dependency from implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message