struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4756) Use TextProviderFactory instead of TextProvider as bean's dependency
Date Fri, 17 Mar 2017 07:12:41 GMT

    [ https://issues.apache.org/jira/browse/WW-4756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929511#comment-15929511
] 

ASF GitHub Bot commented on WW-4756:
------------------------------------

GitHub user lukaszlenart opened a pull request:

    https://github.com/apache/struts/pull/123

    WW-4756: Introduce TextFactoryProvider

    This PR introduces a dedicated interface `TextProviderFactory` with a default implementation
to allow easier further customisations by users.
    
    Implements [WW-4756](https://issues.apache.org/jira/browse/WW-4756)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukaszlenart/struts text-provider-factory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit 4f46f151844bcef39cd631a6fb1cd781fd34224a
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-16T13:39:06Z

    Adds missing class header with license

commit 9376bb0ca16595cac0a1d03fb7b4fa55ab66a8f3
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-16T13:43:07Z

    Renames TextProviderFactory into StrutsTextProviderFactory

commit 54974223fa1f6a66d8c1d61b7b18c94ef5c50386
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-16T13:55:35Z

    Extracts TextProviderFactory interface

commit 3b73544a8ff5e9d96885147bf25c7c2598ac6b21
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T06:49:33Z

    Uses existing instance instead of creating a new one

commit 207ac1774439f72cdfab32c45a3c59ba5a972899
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T06:51:12Z

    Defines proper interfaces and default implementation in configuration

commit 16d1d60ed826c639d2298b77b27c184d9684f21c
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T06:51:57Z

    Uses dedicated logger instead the one from parent class

commit 944b1a2303536023973456d6685f9ab86a775cb0
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T06:59:50Z

    Injects proper dependencies into tag

commit ee6c927db6663741c3d0179e16687704359ea40c
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T07:02:24Z

    Drops unavailable dependency

commit c039685cf946f5e9864ae175a14f3ccdc0edbe59
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T07:02:52Z

    Moves bean into same area are other releated to it beans

commit 132829cc244d60692e3547c5c40b72e29eea1a9e
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T07:03:28Z

    Defines bean in test configuration

commit e8a598c7bc83752f488ad4ccccd0d11a64df3f03
Author: Lukasz Lenart <lukaszlenart@apache.org>
Date:   2017-03-17T07:03:48Z

    Updates test to use the new injectable factory

----


> Use TextProviderFactory instead of TextProvider as bean's dependency
> --------------------------------------------------------------------
>
>                 Key: WW-4756
>                 URL: https://issues.apache.org/jira/browse/WW-4756
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.5.10
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>             Fix For: 2.5.next
>
>
> Right now a TextProvider interface is implemented by the ActionSupport class which can
be misleading and hard to distinguish as bean when it comes to injecting a proper implementation
(e.g. using Spring).
> Separating the TextProvider interface from how it is built should solve the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message