Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Fri, 24 Feb 2017 19:26:44 +0000 (UTC)
From: "Yasser Zamani (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13040981.1486475055000.59519.1487964404189@Atlassian.JIRA>
In-Reply-To: <JIRA.13040981.1486475055000@Atlassian.JIRA>
References: <JIRA.13040981.1486475055000@Atlassian.JIRA> <JIRA.13040981.1486475055582@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (WW-4742) Problem with escape when the key
 from getText has no value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 24 Feb 2017 19:26:49 -0000


    [ https://issues.apache.org/jira/browse/WW-4742?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1588336=
7#comment-15883367 ]=20

Yasser Zamani edited comment on WW-4742 at 2/24/17 7:26 PM:
------------------------------------------------------------

[~mtsbarbosa], your application should not reach those lines normally becau=
se those lines will execute only if Struts cannot resolve your key (i.e. Ob=
rigat=C3=B3rio) to a value. If you want just a constant string (i.e. "Obrig=
at=C3=B3rio - not mapped word in any dictionary") there, then you do not ne=
ed +<@s.text+ tag at all and if you need to resolve the "Obrigat=C3=B3rio" =
to a string according to user selected locale, then create a file named <yo=
ur_action_name>_<locale>.properties beside your action which returns that f=
tl and *save it as ISO-8859-1* e.g.
{code:title=3DMyFtlAction.properties|borderStyle=3Dsolid}
Obrigat=C3=B3rio=3DRequired
{code}
{code:title=3DMyFtlAction_de.properties|borderStyle=3Dsolid}
Obrigat=C3=B3rio=3Dverplicht
{code}
then *save your message.ftl as UTF-8* as below
{code:title=3Dmessage.ftl|borderStyle=3Dsolid}
...
<@s.text name=3D"Obrigat=C3=B3rio" />
...
{code}

Currently Struts just pass a Locale to freemarker rather than any encoding,=
 so freemarker uses it's default (UTF-8) to read your ftl files.

I will be working on it if Struts can also provide the encoding for underly=
ing freemarker, which will enable you to save ftl files as different encodi=
ngs. [~lukaszlenart], is it needed to working on? however, freemarker has s=
ome locale-encoding mapping which simply can be enabled in Struts.


was (Author: yasser.zamani):
[~mtsbarbosa], your application should not reach those lines normally becau=
se those lines will execute only if Struts cannot resolve your key (i.e. Ob=
rigat=C3=B3rio) to a value. If you want just a constant string (i.e. "Obrig=
at=C3=B3rio - not mapped word in any dictionary") there, then you do not ne=
ed +<@s.text+ tag at all and if you need to resolve the "Obrigat=C3=B3rio" =
to a string according to user selected locale, then create a file named <yo=
ur_action_name>_<locale>.properties beside your action which returns that f=
tl and *save it as ISO-8859-1* e.g.
{code:title=3DMyFtlAction.properties|borderStyle=3Dsolid}
Obrigat=C3=B3rio=3DRequired
{code}
{code:title=3DMyFtlAction_de.properties|borderStyle=3Dsolid}
Obrigat=C3=B3rio=3Dverplicht
{code}
then *save your message.ftl as UTF-8* as below
{code:title=3Dmessage.ftl|borderStyle=3Dsolid}
...
<@s.text name=3D"Obrigat=C3=B3rio - not mapped word in any dictionary" />
...
{code}

Currently Struts just pass a Locale to freemarker rather than any encoding,=
 so freemarker uses it's default (UTF-8) to read your ftl files.

I will be working on it if Struts can also provide the encoding for underly=
ing freemarker, which will enable you to save ftl files as different encodi=
ngs. [~lukaszlenart], is it needed to working on? however, freemarker has s=
ome locale-encoding mapping which simply can be enabled in Struts.

> Problem with escape when the key from getText has no value
> ----------------------------------------------------------
>
>                 Key: WW-4742
>                 URL: https://issues.apache.org/jira/browse/WW-4742
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Tags
>    Affects Versions: 2.5.8, 2.5.10
>            Reporter: Mateus Carvalho
>            Priority: Minor
>             Fix For: 2.5.next
>
>
> When using an encoding like ISO-8859-1 and having the following situation=
:
> {code:title=3Dmessage.ftl|borderStyle=3Dsolid}
> ...
> <@s.text name=3D"Obrigat=C3=B3rio - not mapped word in any dictionary" />
> ...
> {code}
> We have the following output after update 2.5.8:
> {code}
> Obrigat\u00F3rio - not mapped word in any dictionary
> {code}
> After careful look at the source code and issues from the 2.5.8 I found t=
he problem happens just in one added line on WW-4712, the following part of=
 the code:
> {code:title=3DTextProviderHelper.java|borderStyle=3Dsolid}
> ...
> public static String getText(String key, String defaultMessage, List<Obje=
ct> args, ValueStack stack, boolean searchStack) {
> ...
> //This escape causes the problem
> msg =3D StringEscapeUtils.escapeEcmaScript(msg);
> ...
> }
> ...
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)