Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 6 Feb 2017 21:56:41 +0000 (UTC)
From: "Adam Greenfield (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13040775.1486416963000.9821.1486418201717@Atlassian.JIRA>
In-Reply-To: <JIRA.13040775.1486416963000@Atlassian.JIRA>
References: <JIRA.13040775.1486416963000@Atlassian.JIRA> <JIRA.13040775.1486416963744@jira-lw-us.apache.org>
Subject: [jira] [Updated] (WW-4741) Http Sessions forcefully created for all
 requests using I18nInterceptor with default Storage value.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Feb 2017 21:56:46 -0000


     [ https://issues.apache.org/jira/browse/WW-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Greenfield updated WW-4741:
--------------------------------
    Summary: Http Sessions forcefully created for all requests using I18nInterceptor with default Storage value.  (was: Http Sessions forcefully created for all requests using I18nInterceptor)

> Http Sessions forcefully created for all requests using I18nInterceptor with default Storage value.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: WW-4741
>                 URL: https://issues.apache.org/jira/browse/WW-4741
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.5.10
>            Reporter: Adam Greenfield
>
> Changes made in WW-4730 for store and read functions cause an httpSession to be created for every request that uses I18nInterceptor.
> Current code checks for 
> {noformat}Map<String, Object> session = invocation.getInvocationContext().getSession(){noformat}
> to be null and then calls 
> {noformat}ServletActionContext.getRequest().getSession(){noformat}
> (notice how the second one references the HttpServletRequest.  The HttpServletRequest Session and and the InvocationContext session are different.  The request's session can be null, even if the InvocationContext's session is not). 
> Calling .getSession() in this manner forcefully creates a session.
>  An appropriate check here might be 
> {noformat}HttpSession httpSession = ServletActionContext.getRequest().getSession(false); 
> if(httpSession != null) {
> ... // get sessionId and synchronize on it
> }
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)