Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72290200C1A for ; Mon, 13 Feb 2017 23:15:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 70AA8160B60; Mon, 13 Feb 2017 22:15:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BA9D5160B4A for ; Mon, 13 Feb 2017 23:15:49 +0100 (CET) Received: (qmail 78327 invoked by uid 500); 13 Feb 2017 22:15:48 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 78317 invoked by uid 99); 13 Feb 2017 22:15:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 22:15:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5CC771A00AD for ; Mon, 13 Feb 2017 22:15:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id b0rSMZ5VOZc6 for ; Mon, 13 Feb 2017 22:15:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 02E645F30A for ; Mon, 13 Feb 2017 22:15:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1CB5DE0626 for ; Mon, 13 Feb 2017 22:15:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CDE2C21D67 for ; Mon, 13 Feb 2017 22:15:41 +0000 (UTC) Date: Mon, 13 Feb 2017 22:15:41 +0000 (UTC) From: "Yasser Zamani (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4528) ChainingInterceptor does not handle lists correctly for excludes and includes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Feb 2017 22:15:50 -0000 [ https://issues.apache.org/jira/browse/WW-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864564#comment-15864564 ] Yasser Zamani commented on WW-4528: ----------------------------------- I also added an Unit test at [this commit|https://github.com/apache/struts/pull/116/commits/805cdd7754400149e166edc80b92fa2d67133d39] which checks for any similar issue occurrence in future. This Unit test fails for current code but passes for [PR#116|https://github.com/apache/struts/pull/116]. > ChainingInterceptor does not handle lists correctly for excludes and includes > ----------------------------------------------------------------------------- > > Key: WW-4528 > URL: https://issues.apache.org/jira/browse/WW-4528 > Project: Struts 2 > Issue Type: Bug > Components: Core Interceptors > Affects Versions: 2.3.24 > Reporter: nikos dimitrakas > Fix For: 2.5.next > > > The ChainingInterceptor has two parameters includes and excludes that according to the documentation and the code are Collection, but the setters don't handle the specified values (that are loaded from the struts.xml) as lists. So if i specify for example > > x,y,z > > the includes variable of the interceptor becomes a Collection of one string with the value "x,y,z" instead of a Collection of three strings "x", "y" and "z". > The behaviour should instead be similar to the ParametersInterceptor's excludeParams or MethodFilterInterceptor's excludeMethods and includeMethods. > It would also be good if the documentation included information and an example with a list of parameters. The current documentation (https://struts.apache.org/docs/chaining-interceptor.html) only says that the parameters are lists, but the example only has one parameter -- This message was sent by Atlassian JIRA (v6.3.15#6346)