struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "zhouyanming (JIRA)" <j...@apache.org>
Subject [jira] [Created] (WW-4744) AnnotationWorkflowInterceptor should supports non-public annotated methods
Date Tue, 14 Feb 2017 01:18:42 GMT
zhouyanming created WW-4744:
-------------------------------

             Summary: AnnotationWorkflowInterceptor should supports non-public annotated methods
                 Key: WW-4744
                 URL: https://issues.apache.org/jira/browse/WW-4744
             Project: Struts 2
          Issue Type: Improvement
          Components: Core Interceptors
            Reporter: zhouyanming


{code:java}
@Before
protected String prepare(){
    //TODO
    return null;
}
{code}
[https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/interceptor/annotations/AnnotationWorkflowInterceptor.java#L115]
{code:java}
List<Method> methods = new ArrayList<>(AnnotationUtils.getAnnotatedMethods(action.getClass(),
Before.class));
{code}
[https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java#L123]
{code:java}
for (Method m : clazz.getMethods()) 
{code}
clazz.getMethods() only return public methods, so method "prepare" will be excluded, and protected
modifier is a good practice for intercept method.We should improve AnnotationUtils.getAnnotatedMethods()
to return all methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message