struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4737) Array-of-null parameters are converted to arrays containing "null"
Date Wed, 01 Feb 2017 02:30:52 GMT

    [ https://issues.apache.org/jira/browse/WW-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847894#comment-15847894
] 

ASF GitHub Bot commented on WW-4737:
------------------------------------

GitHub user ThrawnCA opened a pull request:

    https://github.com/apache/struts/pull/115

    WW-4737 Properly handle arrays containing nulls

    Don't convert null to "null"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ThrawnCA/struts WW-4737

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 58667e64970c528461cf7c5835f9a253c969f737
Author: antuarc <carl.antuar@dsiti.qld.gov.au>
Date:   2017-02-01T02:26:31Z

    [WW-4737] preserve nulls instead of converting them to the string 'null'
    
    - Also simplify if-else logic to be more readable and avoid double-negatives

commit 26bc9cd64bd9e69f7bf2e1076150806581c355f4
Author: antuarc <carl.antuar@dsiti.qld.gov.au>
Date:   2017-02-01T02:27:02Z

    [WW-4737] add unit testing for parameters being converted to string arrays

----


> Array-of-null parameters are converted to arrays containing "null"
> ------------------------------------------------------------------
>
>                 Key: WW-4737
>                 URL: https://issues.apache.org/jira/browse/WW-4737
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.5, 2.5.8
>            Reporter: Mitth'raw'nuruodo
>             Fix For: 2.5.next
>
>
> The {{org.apache.struts2.dispatcher.Parameter.Request}} class (added in Struts 2.5.3)
incorrectly handles arrays containing null; it converts them to arrays containing the string
"null" (using {{String.valueOf}}).
> This is breaking one of our applications; some pages are OK, but on other pages, every
non-provided field is populated with "null".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message