struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4528) ChainingInterceptor does not handle lists correctly for excludes and includes
Date Thu, 02 Feb 2017 22:45:51 GMT

    [ https://issues.apache.org/jira/browse/WW-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850675#comment-15850675
] 

ASF GitHub Bot commented on WW-4528:
------------------------------------

GitHub user yasserzamani opened a pull request:

    https://github.com/apache/struts/pull/116

    [WW-4528] handling ChainingInterceptor excludes and includes lists

    With these changes, they will be handled as comma separated String like what ParameterFilterInterceptor
do.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yasserzamani/struts WW-4528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
    
----

----


> ChainingInterceptor does not handle lists correctly for excludes and includes
> -----------------------------------------------------------------------------
>
>                 Key: WW-4528
>                 URL: https://issues.apache.org/jira/browse/WW-4528
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.24
>            Reporter: nikos dimitrakas
>             Fix For: 2.5.next
>
>
> The ChainingInterceptor has two parameters includes and excludes that according to the
documentation and the code are Collection<String>, but the setters don't handle the
specified values (that are loaded from the struts.xml) as lists. So if i specify for example
> <interceptor-ref name="chain">
>        <param name="includes">x,y,z</param>
> </interceptor-ref>
> the includes variable of the interceptor becomes a Collection of one string with the
value "x,y,z" instead of a Collection of three strings "x", "y" and "z".
> The behaviour should instead be similar to the ParametersInterceptor's excludeParams
or MethodFilterInterceptor's excludeMethods and includeMethods.
> It would also be good if the documentation included information and an example with a
list of parameters. The current documentation (https://struts.apache.org/docs/chaining-interceptor.html)
only says that the parameters are lists, but the example only has one parameter



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message