Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1346200BF7 for ; Mon, 9 Jan 2017 11:53:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AFF6E160B49; Mon, 9 Jan 2017 10:53:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A5FB160B3B for ; Mon, 9 Jan 2017 11:53:05 +0100 (CET) Received: (qmail 22569 invoked by uid 500); 9 Jan 2017 10:52:59 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 22478 invoked by uid 99); 9 Jan 2017 10:52:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 10:52:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D96D32C0453 for ; Mon, 9 Jan 2017 10:52:58 +0000 (UTC) Date: Mon, 9 Jan 2017 10:52:58 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4730) TokenInterceptor synchronized on session.getId().intern() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 09 Jan 2017 10:53:05 -0000 [ https://issues.apache.org/jira/browse/WW-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811454#comment-15811454 ] ASF subversion and git services commented on WW-4730: ----------------------------------------------------- Commit fc6ffba9cf08cbd709be89f7df3edc7475567e4e in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=fc6ffba ] WW-4730 Uses session.getId().intern() to properly lock down session > TokenInterceptor synchronized on session.getId().intern() > --------------------------------------------------------- > > Key: WW-4730 > URL: https://issues.apache.org/jira/browse/WW-4730 > Project: Struts 2 > Issue Type: Bug > Components: Core Interceptors > Affects Versions: 2.5.x > Reporter: Simone Cordaro > Labels: interceptors, patch, token > Fix For: 2.5.next > > Attachments: TokenInterceptor.java > > > As already done on TokenSessionStoreInterceptor, TokenInterceptor's handleToken method need to be synchronized on "session.getId().intern()" instead of "session" -- This message was sent by Atlassian JIRA (v6.3.4#6332)