Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Tue, 20 Dec 2016 16:01:00 +0000 (UTC)
From: "adam brin (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.13029486.1482247690000.563766.1482249660881@Atlassian.JIRA>
In-Reply-To: <JIRA.13029486.1482247690000@Atlassian.JIRA>
References: <JIRA.13029486.1482247690000@Atlassian.JIRA> <JIRA.13029486.1482247690979@arcas>
Subject: [jira] [Commented] (WW-4726) MaxMultiPartUpload limited to 2GB
 (Long --> Integer)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 20 Dec 2016 16:01:02 -0000


    [ https://issues.apache.org/jira/browse/WW-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764518#comment-15764518 ] 

adam brin commented on WW-4726:
-------------------------------

thanks. This is a blocker for us for deploying any new version of our app as we regularly get uploads > 2GB. The change seems to try and unify the normal multi-part handler with the pell-multipart-plugin which uses http.utils.multipartrequest.ServletMultipartRequest and requires an int. I'd create a pull request, but I'm not familiar with this plugin or the overall implications.

> MaxMultiPartUpload limited to 2GB (Long --> Integer)
> ----------------------------------------------------
>
>                 Key: WW-4726
>                 URL: https://issues.apache.org/jira/browse/WW-4726
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core, Dispatch Filter
>    Affects Versions: 2.5.8
>            Reporter: adam brin
>             Fix For: 2.5.next
>
>
> In the following commit, the  {{org.apache.struts2.dispatcher.multipart.AbstractMultiPartRequest.setMaxSize}} was changed from being a Long to being an Integer.  The {{maxMultiPartSize}} was calculated in Bytes and thus, by changing the format, it limits the maximum from over 9EB(exabytes) to just around 2GB. 
> Worse, the default value appears to have been left probably as Long.MAX_SIZE which means that if no value is provided then you get a NumberFormatException thrown.
> https://git-wip-us.apache.org/repos/asf/struts/repo?p=struts.git;a=commitdiff;h=4de8309d0aebb75d409119f2d4a6d06491dda2b4


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)