Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6DF6A200BF0 for ; Fri, 30 Dec 2016 14:12:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6CA58160B24; Fri, 30 Dec 2016 13:12:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DC25C160B3F for ; Fri, 30 Dec 2016 14:11:59 +0100 (CET) Received: (qmail 73723 invoked by uid 500); 30 Dec 2016 13:11:58 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 73439 invoked by uid 99); 30 Dec 2016 13:11:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Dec 2016 13:11:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AE9F12C1F54 for ; Fri, 30 Dec 2016 13:11:58 +0000 (UTC) Date: Fri, 30 Dec 2016 13:11:58 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4102) ActionSupport.LOG should be private MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 30 Dec 2016 13:12:00 -0000 [ https://issues.apache.org/jira/browse/WW-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787643#comment-15787643 ] ASF subversion and git services commented on WW-4102: ----------------------------------------------------- Commit 3ce21403ee3df02aba11ae32c5e7ca54875ad220 in struts's branch refs/heads/master from [~lukaszlenart] [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3ce2140 ] WW-4102 Reduces LOG visibility > ActionSupport.LOG should be private > ----------------------------------- > > Key: WW-4102 > URL: https://issues.apache.org/jira/browse/WW-4102 > Project: Struts 2 > Issue Type: Improvement > Components: Core Actions > Affects Versions: 2.3.14.3 > Reporter: Marcin Kamionowski > Assignee: Lukasz Lenart > Fix For: 2.5.next > > > ActionSupport is base class for actions. Actions cannot (or at least shouldn't) use ActionSupport.LOG because localisation source of messages is much harder in this situation. When ActionSuport.LOG is protected, some programmers might accidentally use this instance (LOG is popular name for loggers). -- This message was sent by Atlassian JIRA (v6.3.4#6332)