struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "adam brin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4726) MaxMultiPartUpload limited to 2GB (Long --> Integer)
Date Tue, 20 Dec 2016 16:01:00 GMT

    [ https://issues.apache.org/jira/browse/WW-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764518#comment-15764518
] 

adam brin commented on WW-4726:
-------------------------------

thanks. This is a blocker for us for deploying any new version of our app as we regularly
get uploads > 2GB. The change seems to try and unify the normal multi-part handler with
the pell-multipart-plugin which uses http.utils.multipartrequest.ServletMultipartRequest and
requires an int. I'd create a pull request, but I'm not familiar with this plugin or the overall
implications.

> MaxMultiPartUpload limited to 2GB (Long --> Integer)
> ----------------------------------------------------
>
>                 Key: WW-4726
>                 URL: https://issues.apache.org/jira/browse/WW-4726
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core, Dispatch Filter
>    Affects Versions: 2.5.8
>            Reporter: adam brin
>             Fix For: 2.5.next
>
>
> In the following commit, the  {{org.apache.struts2.dispatcher.multipart.AbstractMultiPartRequest.setMaxSize}}
was changed from being a Long to being an Integer.  The {{maxMultiPartSize}} was calculated
in Bytes and thus, by changing the format, it limits the maximum from over 9EB(exabytes) to
just around 2GB. 
> Worse, the default value appears to have been left probably as Long.MAX_SIZE which means
that if no value is provided then you get a NumberFormatException thrown.
> https://git-wip-us.apache.org/repos/asf/struts/repo?p=struts.git;a=commitdiff;h=4de8309d0aebb75d409119f2d4a6d06491dda2b4



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message