struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4102) ActionSupport.LOG should be private
Date Fri, 30 Dec 2016 13:11:58 GMT

    [ https://issues.apache.org/jira/browse/WW-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787643#comment-15787643
] 

ASF subversion and git services commented on WW-4102:
-----------------------------------------------------

Commit 3ce21403ee3df02aba11ae32c5e7ca54875ad220 in struts's branch refs/heads/master from
[~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=3ce2140 ]

WW-4102 Reduces LOG visibility


> ActionSupport.LOG should be private
> -----------------------------------
>
>                 Key: WW-4102
>                 URL: https://issues.apache.org/jira/browse/WW-4102
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.3.14.3
>            Reporter: Marcin Kamionowski
>            Assignee: Lukasz Lenart
>             Fix For: 2.5.next
>
>
> ActionSupport is base class for actions. Actions cannot (or at least shouldn't) use ActionSupport.LOG
because localisation source of messages is much harder in this situation. When ActionSuport.LOG
is protected, some programmers might accidentally use this instance (LOG is popular name for
loggers).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message