struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4715) Scope interceptor always resets because of org.apache.struts2.dispatcher.HttpParameters
Date Wed, 16 Nov 2016 08:01:13 GMT

    [ https://issues.apache.org/jira/browse/WW-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669767#comment-15669767
] 

Hudson commented on WW-4715:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-JDK7-master #554 (See [https://builds.apache.org/job/Struts-JDK7-master/554/])
WW-4715 Uses isDefined function instead of null-checking (lukaszlenart: rev a245226b7f1fa2a2cd94508b132f0220989c1e5b)
* (edit) core/src/main/java/org/apache/struts2/interceptor/ProfilingActivationInterceptor.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/ScopeInterceptor.java


> Scope interceptor always resets because of org.apache.struts2.dispatcher.HttpParameters
> ---------------------------------------------------------------------------------------
>
>                 Key: WW-4715
>                 URL: https://issues.apache.org/jira/browse/WW-4715
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.5.5
>            Reporter: Greg Baker
>             Fix For: 2.5.6
>
>
> Line 302 of org.apache.struts2.interceptor.ScopeInterceptor performs a not-null check
to see if a session reset parameter exists by calling com.opensymphony.xwork2.ActionContext.getParameters().get(...).
> The return type of getParameters() is org.apache.struts2.dispatcher.HttpParameters, and
HttpParamters.get() never returns null on a missing parameter, causing the not-null check
to always evaluate to true.
> This breaks the interceptor by short circuiting the scoped variable injection.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message