Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 10 Oct 2016 09:46:20 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12770108.1422287193000.780632.1476092780611@Atlassian.JIRA>
In-Reply-To: <JIRA.12770108.1422287193000@Atlassian.JIRA>
References: <JIRA.12770108.1422287193000@Atlassian.JIRA> <JIRA.12770108.1422287193950@arcas>
Subject: [jira] [Commented] (WW-4453) <s:date/> tag doesn't report missing
 value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Oct 2016 09:46:22 -0000


    [ https://issues.apache.org/jira/browse/WW-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561823#comment-15561823 ] 

Hudson commented on WW-4453:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-JDK7-master #539 (See [https://builds.apache.org/job/Struts-JDK7-master/539/])
WW-4453 Reduces level to WARN (lukaszlenart: rev dbf2bcb5cd2130056796ecea2f6f3c1055914097)
* (edit) core/src/main/java/org/apache/struts2/components/Date.java


> <s:date/> tag doesn't report missing value
> ------------------------------------------
>
>                 Key: WW-4453
>                 URL: https://issues.apache.org/jira/browse/WW-4453
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>    Affects Versions: 2.3.20
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.24
>
>
> If you pass a value which isn't {{Date}} or {{Calendar}}, the {{<s:date/>}} ignores it and doesn't report any problems. The problem is here
> {code:java}
> public boolean end(Writer writer, String body) {
>     String msg;
>     java.util.Date date = null;
>     // find the name on the valueStack
>     try {
>         //suport Calendar also
>         Object dateObject = findValue(name);
>         if (dateObject instanceof java.util.Date) {
>             date = (java.util.Date) dateObject;
>         } else if(dateObject instanceof Calendar){
>             date = ((Calendar) dateObject).getTime();
>         }
>     } catch (Exception e) {
>         LOG.error("Could not convert object with key '#0' to a java.util.Date instance", name);
>     }
> {code}
> there must additional {{else}} clause to report missing value, ie:
> {code:java}
>         if (dateObject instanceof java.util.Date) {
>             date = (java.util.Date) dateObject;
>         } else if(dateObject instanceof Calendar){
>             date = ((Calendar) dateObject).getTime();
>         } else {
>             LOG.error(...);
>         }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)