Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 15 Aug 2016 09:28:20 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12979845.1466088293000.303743.1471253300537@Atlassian.JIRA>
In-Reply-To: <JIRA.12979845.1466088293000@Atlassian.JIRA>
References: <JIRA.12979845.1466088293000@Atlassian.JIRA> <JIRA.12979845.1466088293134@arcas>
Subject: [jira] [Commented] (WW-4646) remove ASM 3 from struts2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 15 Aug 2016 09:28:22 -0000


    [ https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420777#comment-15420777 ] 

Lukasz Lenart commented on WW-4646:
-----------------------------------

Yes, there are. The Convention plugin is using ASM3 by default, but this can be overwritten with the Java 8 Support plugin.

> remove ASM 3 from struts2
> -------------------------
>
>                 Key: WW-4646
>                 URL: https://issues.apache.org/jira/browse/WW-4646
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions, Plugin - Convention
>    Affects Versions: 2.5
>            Reporter: adam brin
>            Assignee: Lukasz Lenart
>             Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plugin and 3x for the rest of struts.  A basic search of the codebase suggests that the only direct uses of ASM are via the ClassFinder class in Xwork and used by the Convention plugin.  Based on this [https://issues.apache.org/jira/browse/WW-4435] and [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], I wonder if it might make sense to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in general
> 2. move the ClassFinder class and direct dependencies the convention plugin and make them explicitly dependent on ASM 5x.
> 3. Like other apps like Spring, repackage/embed ASM into it's own package tree so it can live with other versions of ASM.
> -----
> the core issue for us is that there are overlaps between ASM 5 and ASM 3, and become explicit when launching our app with the maven-jetty-plugin. Classes with the same name in both packages though they have different groupIds and thus cause exceptions in startup either due to (a) Missing Classes like EmptyVisitor or (b) incompatible classes. It's our hope that by removing this dual dependency, we can take advantage of Java8 features and also simplify dependency management in our pom.
> thanks


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)