Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Fri, 12 Aug 2016 10:27:20 +0000 (UTC)
From: =?utf-8?Q?Sebastian_G=C3=B6tz_=28JIRA=29?= <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12979845.1466088293000.291027.1470997640628@Atlassian.JIRA>
In-Reply-To: <JIRA.12979845.1466088293000@Atlassian.JIRA>
References: <JIRA.12979845.1466088293000@Atlassian.JIRA> <JIRA.12979845.1466088293134@arcas>
Subject: [jira] [Commented] (WW-4646) remove ASM 3 from struts2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 12 Aug 2016 10:27:22 -0000


    [ https://issues.apache.org/jira/browse/WW-4646?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1541863=
8#comment-15418638 ]=20

Sebastian G=C3=B6tz commented on WW-4646:
------------------------------------

Good job! I am currently stumbling over this since we have already several =
action classes in the next release version that do not work since they use =
Java 8 lambda expressions. Before reverting to loop constructs I have tried=
 to find out a release date for the 2.5.3 release with no success. Maybe Lu=
kas can give me a hint. I need not to know an exact date. But I would be gl=
ad to hear if it will come this month.

> remove ASM 3 from struts2
> -------------------------
>
>                 Key: WW-4646
>                 URL: https://issues.apache.org/jira/browse/WW-4646
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions, Plugin - Convention
>    Affects Versions: 2.5
>            Reporter: adam brin
>            Assignee: Lukasz Lenart
>             Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plu=
gin and 3x for the rest of struts.  A basic search of the codebase suggests=
 that the only direct uses of ASM are via the ClassFinder class in Xwork an=
d used by the Convention plugin.  Based on this [https://issues.apache.org/=
jira/browse/WW-4435] and [http://www.philvarner.com/2015/02/05/using-apache=
-cxf-2-7-struts2-2-3-and-asm-5-with-maven/], I wonder if it might make sens=
e to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in =
general
> 2. move the ClassFinder class and direct dependencies the convention plug=
in and make them explicitly dependent on ASM 5x.
> 3. Like other apps like Spring, repackage/embed ASM into it's own package=
 tree so it can live with other versions of ASM.
> -----
> the core issue for us is that there are overlaps between ASM 5 and ASM 3,=
 and become explicit when launching our app with the maven-jetty-plugin. Cl=
asses with the same name in both packages though they have different groupI=
ds and thus cause exceptions in startup either due to (a) Missing Classes l=
ike EmptyVisitor or (b) incompatible classes. It's our hope that by removin=
g this dual dependency, we can take advantage of Java8 features and also si=
mplify dependency management in our pom.
> thanks


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)