struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3266) getFieldValue() method of ValueStackDataSource uses getDescription() to get field value may not appropriate
Date Fri, 15 Jul 2016 14:12:21 GMT

    [ https://issues.apache.org/jira/browse/WW-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379423#comment-15379423
] 

Hudson commented on WW-3266:
----------------------------

SUCCESS: Integrated in Struts-JDK7-master #495 (See [https://builds.apache.org/job/Struts-JDK7-master/495/])
Patch WW-3266 (lukaszlenart: rev c0670209bac3d911b6f76850a6d36dbea64b91e2)
* plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/ValueStackDataSource.java


> getFieldValue() method of ValueStackDataSource uses getDescription() to get field value
may not appropriate
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3266
>                 URL: https://issues.apache.org/jira/browse/WW-3266
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JasperReports
>    Affects Versions: 2.1.6
>         Environment: JasperReports 3.6
> Groovy 1.5.5
> JDK 1.6 (MAC JDK) 
>            Reporter: Matt Jiang
>             Fix For: 2.5
>
>
> Current implementation:
> {code:java}
> String expression = field.getDescription();
> if (expression == null) {
>     //Description is optional so use the field name as a default
>     expression = field.getName();
> }
> Object value = valueStack.findValue(expression);
> {code}
> Recommended implementation :
> {code:java}
> String expression = field.getName();
> Object value = valueStack.findValue(expression);
> {code}
> Reason:
> In JasperReports, a description of a field is just like a documentation for this field.
So it may not good to use it as expression.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message