struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim deVos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4605) Refactor MessageStoreInterceptor and use PreResultListener to store messages
Date Thu, 24 Mar 2016 00:17:25 GMT

    [ https://issues.apache.org/jira/browse/WW-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209482#comment-15209482
] 

Jim deVos commented on WW-4605:
-------------------------------

Hi Lukasz!  I noticed your commit replaces using the 'instanceof' operator on invocation.getResult(),
so i'm guessing there was a problem doing it that way, too.  If you're looking to avoid referencing
the result object,  could you do something like this?

{code}
isRedirect = ServletRedirectResult.class.isAssignableFrom(resultConfig.getClassName());
{code}

I ask because my team uses a custom subclass of ServletRedirectResult,   e.g. "org.tdar.struts.ServletRedirectResult".
 After updating to 2.3.8 our messages no longer survive a redirect, and I suspect that this
string comparison is the root cause.  Thanks for your time --Jim


> Refactor MessageStoreInterceptor and use PreResultListener to store messages
> ----------------------------------------------------------------------------
>
>                 Key: WW-4605
>                 URL: https://issues.apache.org/jira/browse/WW-4605
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.3.24
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.28, 2.5
>
>
> See WW-4600 as this issue is similar, when response was already comitted (redirect was
send, JSP was rendered), logic in {{after}} method won't work as it isn't possible to modify
session when response was comitted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message