Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3DD8C1826C for ; Thu, 25 Feb 2016 19:39:24 +0000 (UTC) Received: (qmail 57361 invoked by uid 500); 25 Feb 2016 19:39:19 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 57279 invoked by uid 500); 25 Feb 2016 19:39:18 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 56792 invoked by uid 99); 25 Feb 2016 19:39:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2016 19:39:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 957B02C1F6D for ; Thu, 25 Feb 2016 19:39:18 +0000 (UTC) Date: Thu, 25 Feb 2016 19:39:18 +0000 (UTC) From: "Hudson (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (WW-4595) Validators can no longer retrieve messages from property files for ModelDriven objects. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167727#comment-15167727 ] Hudson commented on WW-4595: ---------------------------- SUCCESS: Integrated in Struts-JDK6-support-2.3 #979 (See [https://builds.apache.org/job/Struts-JDK6-support-2.3/979/]) WW-4595 Resolves regression issue but keeping support for custom text (lukaszlenart: rev 1b4868df3ed0a82098a34048e4a22333242667de) * xwork-core/src/main/java/com/opensymphony/xwork2/validator/DelegatingValidatorContext.java * xwork-core/src/test/java/com/opensymphony/xwork2/validator/VisitorFieldValidatorTest.java * xwork-core/src/test/resources/com/opensymphony/xwork2/TestBean.properties * xwork-core/src/test/resources/com/opensymphony/xwork2/validator/VisitorValidatorTestAction.properties > Validators can no longer retrieve messages from property files for ModelDriven objects. > --------------------------------------------------------------------------------------- > > Key: WW-4595 > URL: https://issues.apache.org/jira/browse/WW-4595 > Project: Struts 2 > Issue Type: Bug > Components: XML Validators > Affects Versions: 2.3.20 > Reporter: Rob Stokes > Assignee: Lukasz Lenart > Fix For: 2.3.25, 2.5 > > > I have a Action with a VistorFieldValidator for my ModelDriven object (Model.class), prior to version 2.3.20 the RequiredStringValidator looked up the message in the Model.properties file. Since 2.3.20 the validators can no longer retrieve messages from property files for the ModelDriven object. The DelegatingValidatorContext always returns the TextProvider for the Action instead of the ModelDriven object in the makeTextProvider method. > The DelegatingValidatorContext was changed in WW-4202. > I would submit a patch but I'm not sure of the correct behavior. > Example app with test case is here https://github.com/RLStokes/struts2-modeldriven. > The tests pass with struts 2.3.15.1 they fail with 2.3.20. -- This message was sent by Atlassian JIRA (v6.3.4#6332)