struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4595) Validators can no longer retrieve messages from property files for ModelDriven objects.
Date Thu, 25 Feb 2016 19:39:18 GMT

    [ https://issues.apache.org/jira/browse/WW-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167727#comment-15167727
] 

Hudson commented on WW-4595:
----------------------------

SUCCESS: Integrated in Struts-JDK6-support-2.3 #979 (See [https://builds.apache.org/job/Struts-JDK6-support-2.3/979/])
WW-4595 Resolves regression issue but keeping support for custom text (lukaszlenart: rev 1b4868df3ed0a82098a34048e4a22333242667de)
* xwork-core/src/main/java/com/opensymphony/xwork2/validator/DelegatingValidatorContext.java
* xwork-core/src/test/java/com/opensymphony/xwork2/validator/VisitorFieldValidatorTest.java
* xwork-core/src/test/resources/com/opensymphony/xwork2/TestBean.properties
* xwork-core/src/test/resources/com/opensymphony/xwork2/validator/VisitorValidatorTestAction.properties


> Validators can no longer retrieve messages from property files for ModelDriven objects.
> ---------------------------------------------------------------------------------------
>
>                 Key: WW-4595
>                 URL: https://issues.apache.org/jira/browse/WW-4595
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.3.20
>            Reporter: Rob Stokes
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.25, 2.5
>
>
> I have a Action with a VistorFieldValidator for my ModelDriven object (Model.class),
prior to version 2.3.20 the RequiredStringValidator looked up the message in the Model.properties
file. Since 2.3.20 the validators can no longer retrieve messages from property files for
the ModelDriven object. The DelegatingValidatorContext always returns the TextProvider for
the Action instead of the ModelDriven object in the makeTextProvider method.
> The DelegatingValidatorContext was changed in WW-4202.
> I would submit a patch but I'm not sure of the correct behavior.
> Example app with test case is here https://github.com/RLStokes/struts2-modeldriven.
> The tests pass with struts 2.3.15.1 they fail with 2.3.20.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message