struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (WW-4563) Regressions after upgrading to to obtain security fix
Date Thu, 25 Feb 2016 17:31:18 GMT


ASF subversion and git services commented on WW-4563:

Commit 5cfe05075b24869c0770ef4df9d58c0ab52bc459 in struts's branch refs/heads/support-2-3
from [~lukaszlenart]
[;h=5cfe050 ]

WW-4563 Reverts checking if value is excluded and uses Internal Security Mechanism

> Regressions after upgrading to to obtain security fix
> --------------------------------------------------------------
>                 Key: WW-4563
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.24
>            Reporter: Seolyoung Park
>              Labels: security
>             Fix For: 2.3.25
> We recently tried to update from to  based on 
>, we are hitting regressions issues due to
a change in CookieInterceptor.  
> It's currently using the same accepted_pattern to check out both name & value to
pass around the cookies. When the cookie values are simple, it works.  When the cookie value
carries a special chars for example a url is the cookie value, it fails with the existing
pattern and it is not passed to actions. 
> I didn't find a way getting around this in the config and this has been a blocker for
us to update to the version.
> Why are we checking for cookie values with the same hardcoded pattern only ?  If there
is a way to workaround this in the config? 
>     private static final String ACCEPTED_PATTERN = "[a-zA-Z0-9\\.\\]\\[_'\\s]+";
>     .....    
> protected boolean isAcceptableValue(String value) {
>         return !isExcluded(value) && isAccepted(value);
>     }

This message was sent by Atlassian JIRA

View raw message