Return-Path: 
 <issues-return-26602-apmail-struts-issues-archive=struts.apache.org@struts.apache.org>
X-Original-To: apmail-struts-issues-archive@minotaur.apache.org
Delivered-To: apmail-struts-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0B14E18389
	for <apmail-struts-issues-archive@minotaur.apache.org>;
 Mon,  4 Jan 2016 19:17:41 +0000 (UTC)
Received: (qmail 50533 invoked by uid 500); 4 Jan 2016 19:17:40 -0000
Delivered-To: apmail-struts-issues-archive@struts.apache.org
Received: (qmail 50461 invoked by uid 500); 4 Jan 2016 19:17:40 -0000
Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@struts.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@struts.apache.org>
List-Post: <mailto:issues@struts.apache.org>
List-Id: <issues.struts.apache.org>
Reply-To: dev@struts.apache.org
Delivered-To: mailing list issues@struts.apache.org
Received: (qmail 50338 invoked by uid 99); 4 Jan 2016 19:17:40 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2016 19:17:40 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 10D852C1F56
	for <issues@struts.apache.org>; Mon,  4 Jan 2016 19:17:40 +0000 (UTC)
Date: Mon, 4 Jan 2016 19:17:40 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12468250.1277903230000.12539.1451935060066@Atlassian.JIRA>
In-Reply-To: <JIRA.12468250.1277903230000@Atlassian.JIRA>
References: <JIRA.12468250.1277903230000@Atlassian.JIRA>
 <JIRA.12468250.1277903230306@arcas>
Subject: [jira] [Commented] (WW-3462) connection open after report
 generation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/WW-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081611#comment-15081611 ] 

ASF subversion and git services commented on WW-3462:
-----------------------------------------------------

Commit 316b8a926e7bec85c83f69b2460a8b7d938d1686 in struts's branch refs/heads/master from Victor Sosa
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=316b8a9 ]

Patch WW-3462

connection open after report generation

Now the connection is close after been used.

> connection open after report generation
> ---------------------------------------
>
>                 Key: WW-3462
>                 URL: https://issues.apache.org/jira/browse/WW-3462
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - JasperReports
>    Affects Versions: 2.1.8
>         Environment: jdk1.5.0_16 
>            Reporter: Salva
>             Fix For: 2.3.25, 2.5
>
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> If a report generation was called with connection like following code, database connection will not be closed. I suggest to modify doExecute method of org.apache.struts2.views.jasperreports.JasperReportsResult class after the exportReportToBytes, by adding, in case of conn not null, the conn closing.
> struts.xml
> ...
> <action name="report" class="myorg.actions.tests.Report">
>     <result name="success" type="jasper">
>         <param name="location">/test/Report.jasper</param>
>         <param name="connection">myConnection</param>
>         <param name="contentDisposition">attachment</param>
>         <param name="format">PDF</param>
>     </result>
> </action>
> ....
> Action execute method code
> ...
> DataSource ds = (DataSource) ictx.lookup("java:jdbc/myApp");
> myConnection = ds.getConnection();
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)