struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4594) Configure TilesDefs by annotating Actions
Date Mon, 25 Jan 2016 12:56:39 GMT

    [ https://issues.apache.org/jira/browse/WW-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115158#comment-15115158
] 

ASF GitHub Bot commented on WW-4594:
------------------------------------

GitHub user cnenning opened a pull request:

    https://github.com/apache/struts/pull/85

    WW-4594: Configure TilesDefs by annotating Actions

    Adds annotations for each element from `tiles.xml` to annotate actions. Those annotations
are processed by a new class in tiles-plugin which is used by TilesResult.
    
    With those annotations it is possible to keep `tiles.xml` very short (e.g. just put layout
in there) and configure concrete tiles-definitions just by annotating actions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cnenning/struts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit d9f4054b1367cd7ab6e3f22b9cc677f62def4e83
Author: cnenning <cnenning@apache.org>
Date:   2016-01-22T13:59:48Z

    fixed tiles showcase by setting dtd to 3.0

commit 9ac326aa2458fe43140c1b13b61c87752d282e3d
Author: cnenning <cnenning@apache.org>
Date:   2016-01-22T14:27:09Z

    Added tiles annotations, see WW-4594.
    
    Added tiles annotations, created StrutsTilesAnnotationProcessor to
    create Definitons from them and using it in TilesResult.

commit e50c37c5ba5781900edf53f9ec71b8649471d448
Author: cnenning <cnenning@apache.org>
Date:   2016-01-22T14:27:50Z

    added sample for tiles annotations

commit d76357fd829a3ea8ddca21d625c49b606cca88d5
Author: cnenning <cnenning@apache.org>
Date:   2016-01-25T10:23:10Z

    added tests for StrutsTilesAnnotationProcessor

commit a53deac7ce8732053edd43dddac329448055aef0
Author: cnenning <cnenning@apache.org>
Date:   2016-01-25T12:39:47Z

    updated javadoc

commit b1588ddc84d876a676bab66ad80ec34637e98536
Author: cnenning <cnenning@apache.org>
Date:   2016-01-25T12:50:45Z

    fixed line endings

----


> Configure TilesDefs by annotating Actions
> -----------------------------------------
>
>                 Key: WW-4594
>                 URL: https://issues.apache.org/jira/browse/WW-4594
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Plugin - Tiles
>            Reporter: Christoph Nenning
>            Assignee: Christoph Nenning
>             Fix For: 2.5
>
>
> Large applications often consist of hundrets of actions. IMO it is a major benefit of
struts-convention-plugin that it is not necessary to configure all those actions in xml files.
As xml files would become huge and hard to maintain. The same applies to tiles xml files.
Currently it is necessary to configure tiles-definitions for all those actions in xml files
which makes them huge and hard to maintain.
> It would be great if configuration of tiles-definitions could be done by annotating actions,
in a similar way actions can be configured with annotations from convention-plugin.
> This somewhat relates to WW-3937 and WW-4161



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message