struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4590) Allow to use multiple names in result
Date Tue, 19 Jan 2016 20:06:39 GMT

    [ https://issues.apache.org/jira/browse/WW-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107337#comment-15107337
] 

ASF GitHub Bot commented on WW-4590:
------------------------------------

Github user swiftelan commented on the pull request:

    https://github.com/apache/struts/pull/75#issuecomment-172970495
  
    @aleksandr-m
    
    An annotation attribute that is defined as an array does not have to have the curly braces
to define a single value for that attribute.
    
    Basing a Java API for configuration on XML syntax is a poor implementation. Why not support
the entire XML configuration syntax in the annotation? Java has APIs to express a collection
of items. It is much easier to utilize an array than a comma separated value attribute. The
array allows the developer to clearly express their intent. Utilizing an array does not require
parsing when the configuration value is accessed.


> Allow to use multiple names in result
> -------------------------------------
>
>                 Key: WW-4590
>                 URL: https://issues.apache.org/jira/browse/WW-4590
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Convention, XML Configuration
>    Affects Versions: 2.3.24
>            Reporter: Aleksandr Mashchenko
>            Assignee: Aleksandr Mashchenko
>             Fix For: 2.5
>
>
> Allow to use multiple values in {{result}} tag {{name}} attribute and in {{Result}} annotation
{{name}}.
> So this typical configuration:
> {code:xml}
> <action name="save">
>     <result>success.jsp</result>
>     <result name="error">input-form.jsp</result>
>     <result name="input">input-form.jsp</result>
> </action>
> {code}
> Can be shorten to that:
> {code:xml}
> <action name="save">
>     <result>success.jsp</result>
>     <result name="error, input">input-form.jsp</result>
> </action>
> {code}
> And this annotations:
> {code:java}
> @Action(results = {
>     @Result(name="error", location="input-form.jsp"),
>     @Result(name="input", location="input-form.jsp"),
>     @Result(name="success", location="success.jsp")
> })
> {code}
> To that:
> {code:java}
> @Action(results = {
>     @Result(name="error, input", location="input-form.jsp"),
>     @Result(name="success", location="success.jsp")
> })
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message