struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4456) Got NPE when File Upload Limitation exceeds in portal env.
Date Mon, 18 Jan 2016 16:22:39 GMT

    [ https://issues.apache.org/jira/browse/WW-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105481#comment-15105481
] 

ASF GitHub Bot commented on WW-4456:
------------------------------------

GitHub user victorsosa opened a pull request:

    https://github.com/apache/struts/pull/74

    propose fix for ww-4456

    HI Lukasz,
    
    This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation exceeds in portal
env.
    
    We should catch in any case a FileUploadException, then try to cast down if we want any
info about the exception. Valid subtype of FileUploadException:
    InvalidContentTypeException
    IOFileUploadException
    SizeLimitExceededException
    FileSizeLimitExceededException
    
    I couldn't get the complete test on a running test env, because I had issues getting the
logging to work.
    
    But it seems to works.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/victorsosa/struts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit 073bb9dd587844c1f44c97ba53b8419c83f2583a
Author: victor sosa <victorsosa@users.noreply.github.com>
Date:   2016-01-16T18:45:39Z

    Merge pull request #3 from apache/master
    
    update

commit 81675825723a0f4e7d4d185cd234cb2b900c2577
Author: Victor Sosa <victornsosa@gmail.com>
Date:   2016-01-18T15:34:36Z

    propose fix for WW-4456
    
    Got NPE when File Upload Limitation exceeds in portal env.

----


> Got NPE when  File Upload Limitation exceeds in portal env.
> -----------------------------------------------------------
>
>                 Key: WW-4456
>                 URL: https://issues.apache.org/jira/browse/WW-4456
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Actions, Plugin - Portlet
>    Affects Versions: 2.3.16.3
>         Environment: IBM Websphere Portal 7, Liferay 6.2
>            Reporter: Zhou Shern
>             Fix For: 2.3.x
>
>         Attachments: FileUploadFailedPortal.zip
>
>
> Got NPE when  File Upload Limitation exceeds in portal env.
> {noformat}
> 04:12:53,078 ERROR [http-bio-8080-exec-4][render_portlet_jsp:132] null
> java.lang.NullPointerException
> 	at com.opensymphony.xwork2.util.LocalizedTextUtil.findText(LocalizedTextUtil.java:394)
> 	at org.apache.struts2.dispatcher.multipart.JakartaMultiPartRequest.buildErrorMessage(JakartaMultiPartRequest.java:123)
> 	at org.apache.struts2.dispatcher.multipart.JakartaMultiPartRequest.parse(JakartaMultiPartRequest.java:97)
> 	at org.apache.struts2.dispatcher.multipart.MultiPartRequestWrapper.<init>(MultiPartRequestWrapper.java:81)
> 	at org.apache.struts2.dispatcher.Dispatcher.wrapRequest(Dispatcher.java:803)
> 	at org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher.serviceAction(Jsr168Dispatcher.java:435)
> 	at org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher.processAction(Jsr168Dispatcher.java:299)
> 	at com.liferay.portlet.FilterChainImpl.doFilter(FilterChainImpl.java:71)
> 	at com.liferay.portal.kernel.portlet.PortletFilterUtil.doFilter(PortletFilterUtil.java:48)
> 	at com.liferay.portal.kernel.servlet.PortletServlet.service(PortletServlet.java:112)
> 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> 	at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterChain.doFilter(InvokerFilterChain.java:116)
> 	at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilter.doFilter(InvokerFilter.java:96)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
> 	at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:749)
> 	at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:605)
> 	at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:544)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message