struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4412) Context started without being closed
Date Tue, 19 Jan 2016 14:55:39 GMT

    [ https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106828#comment-15106828
] 

ASF GitHub Bot commented on WW-4412:
------------------------------------

Github user victorsosa commented on a diff in the pull request:

    https://github.com/apache/struts/pull/79#discussion_r50120845
  
    --- Diff: plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java
---
    @@ -110,7 +110,9 @@ public void doExecute(String location, ActionInvocation invocation)
throws Excep
             HttpServletResponse httpResponse = ServletActionContext.getResponse();
     
             Request request = new ServletRequest(applicationContext, httpRequest, httpResponse);
    -
    +        
    +        container.startContext(request);
             container.render(location, request);
    +        container.endContext(request);
    --- End diff --
    
    OK, i will close the PR then :+1: 


> Context started without being closed
> ------------------------------------
>
>                 Key: WW-4412
>                 URL: https://issues.apache.org/jira/browse/WW-4412
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tiles
>    Affects Versions: 2.3.16.3
>            Reporter: Hazem Taji
>             Fix For: 2.5
>
>         Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended. This causes
the context stack later to have extra irrelevant contexts.
> The problem prevents the use of <s:action> tags where actions have tile results
and results in the tile attributes being unrecognized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message