struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3940) Upgrade to Velocity Tools 2.0
Date Wed, 20 Jan 2016 23:41:40 GMT

    [ https://issues.apache.org/jira/browse/WW-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109744#comment-15109744
] 

ASF GitHub Bot commented on WW-3940:
------------------------------------

Github user victorsosa commented on a diff in the pull request:

    https://github.com/apache/struts/pull/84#discussion_r50339318
  
    --- Diff: plugins/sitemesh/src/main/java/org/apache/struts2/sitemesh/VelocityDecoratorServlet.java
---
    @@ -78,17 +88,18 @@ public void init(ServletConfig config) throws ServletException {
             velocityManager.init(config.getServletContext());
     
             // do whatever we have to do to init Velocity
    -        setVelocityEngine(velocityManager.getVelocityEngine());
    -        toolboxManager = velocityManager.getToolboxManager();
    +        getVelocityView().setVelocityEngine(velocityManager.getVelocityEngine());
    +        //getVelocityView().getToolboxFactory(). toolboxManager = velocityManager.getToolboxManager();
    --- End diff --
    
    WARN: I didn't find a way to translate this line to the new API, but the ALL test are
passing


> Upgrade to Velocity Tools 2.0
> -----------------------------
>
>                 Key: WW-3940
>                 URL: https://issues.apache.org/jira/browse/WW-3940
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions, Plugin - Portlet, Plugin - SiteMesh
>    Affects Versions: 2.3.7
>            Reporter: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message