Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Mon, 19 Oct 2015 14:33:05 +0000 (UTC)
From: "adam brin (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12856475.1439757862000.74626.1445265185212@Atlassian.JIRA>
In-Reply-To: <JIRA.12856475.1439757862000@Atlassian.JIRA>
References: <JIRA.12856475.1439757862000@Atlassian.JIRA>
 <JIRA.12856475.1439757862445@arcas>
Subject: [jira] [Commented] (WW-4536) potential memory leak with
 annotationActionValidatorManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/WW-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963389#comment-14963389 ] 

adam brin commented on WW-4536:
-------------------------------

Hi Lukasz,
  Apologies for the delay, I've been traveling.  I downloaded the snapshot and tested about 100 URL requests after removing out @SkipValidation calls, it seems much better. I don't see the entries in the heap analyzer in any quantity.

> potential memory leak with annotationActionValidatorManager
> -----------------------------------------------------------
>
>                 Key: WW-4536
>                 URL: https://issues.apache.org/jira/browse/WW-4536
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.3.20
>            Reporter: adam brin
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.25
>
>         Attachments: Screen Shot 2015-08-16 at 1.48.30 PM.png, Screen Shot 2015-08-16 at 1.49.22 PM.png
>
>
> We've recently been having issues with our app crashing and trying to track down the root causes.  One of the things we've seen is that over the course of 1 day, 50% of our memory (almost 620 MB of 1.2 GB)  is allocated to "com.opensymphony.xwork.validator.AnnotationActionValidatorManager" according to the heap dump. We also see millions of entries in two SynchronizedMap's:
> * validatorCache (1,635,019  entries)
> * validatorFileCache (87,321 entries)
> Looking through the entries in the validator cache, we se entries for every unique page browsed within the app. Note: we're using staticParam mapping and NamedVariable PatternMatching in action names e.g. {{"$\{id\}/$\{slug\}"}} so effectively every url is unique.
> Looking at the source code, should these maps perhaps be "WeakHashMaps" or WeakReferences so that they're disposed of?
> (source code to the app is here: https://bitbucket.org/tdar/tdar.src/src )


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)