struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <>
Subject [jira] [Commented] (WW-4457) FileUploadInterceptor uses injected pattern matcher
Date Mon, 12 Oct 2015 11:24:11 GMT


Hudson commented on WW-4457:

SUCCESS: Integrated in Struts-JDK7-master #371 (See [])
WW-4457 Uses dedicated type to match content type of uploaded files (lukaszlenart: rev 54c64234844488d178e4ac1579ab8194a36b8b4a)
* core/src/main/java/org/apache/struts2/interceptor/
* core/src/main/java/org/apache/struts2/config/
* core/src/main/java/org/apache/struts2/
* core/src/main/java/org/apache/struts2/util/
* core/src/main/java/org/apache/struts2/util/
* core/src/main/resources/struts-default.xml

> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>                 Key: WW-4457
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>            Reporter: Aleksandr Mashchenko
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.24
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher
is set as the default one. Or is there any point in injecting pattern matcher in file upload
> Original report: [“Content-Type not allowed” while uploading an SVG file, that is
in the allowed whitelist|]

This message was sent by Atlassian JIRA

View raw message