Return-Path: 
 <issues-return-25935-apmail-struts-issues-archive=struts.apache.org@struts.apache.org>
X-Original-To: apmail-struts-issues-archive@minotaur.apache.org
Delivered-To: apmail-struts-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CF7D0186E2
	for <apmail-struts-issues-archive@minotaur.apache.org>;
 Wed, 22 Jul 2015 10:10:25 +0000 (UTC)
Received: (qmail 69265 invoked by uid 500); 22 Jul 2015 10:10:04 -0000
Delivered-To: apmail-struts-issues-archive@struts.apache.org
Received: (qmail 69212 invoked by uid 500); 22 Jul 2015 10:10:04 -0000
Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@struts.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@struts.apache.org>
List-Post: <mailto:issues@struts.apache.org>
List-Id: <issues.struts.apache.org>
Reply-To: dev@struts.apache.org
Delivered-To: mailing list issues@struts.apache.org
Received: (qmail 69200 invoked by uid 99); 22 Jul 2015 10:10:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 10:10:04 +0000
Date: Wed, 22 Jul 2015 10:10:04 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12846803.1437555354000.254722.1437559804728@Atlassian.JIRA>
In-Reply-To: <JIRA.12846803.1437555354000@Atlassian.JIRA>
References: <JIRA.12846803.1437555354000@Atlassian.JIRA>
 <JIRA.12846803.1437555354841@arcas>
Subject: [jira] [Commented] (WW-4528) ChainingInterceptor does not handle
 lists correctly for excludes and includes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/WW-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636639#comment-14636639 ] 

Lukasz Lenart commented on WW-4528:
-----------------------------------

{code}
<interceptor-ref name="chain">
  <param name="excludes">{'x','y','x'}</param>
</interceptor-ref>
{code}

http://struts.apache.org/docs/ognl.html#OGNL-Collections(Maps,Lists,Sets)

> ChainingInterceptor does not handle lists correctly for excludes and includes
> -----------------------------------------------------------------------------
>
>                 Key: WW-4528
>                 URL: https://issues.apache.org/jira/browse/WW-4528
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.24
>            Reporter: nikos dimitrakas
>             Fix For: 2.5
>
>
> The ChainingInterceptor has two parameters includes and excludes that according to the documentation and the code are Collection<String>, but the setters don't handle the specified values (that are loaded from the struts.xml) as lists. So if i specify for example
> <interceptor-ref name="chain">
>        <param name="includes">x,y,z</param>
> </interceptor-ref>
> the includes variable of the interceptor becomes a Collection of one string with the value "x,y,z" instead of a Collection of three strings "x", "y" and "z".
> The behaviour should instead be similar to the ParametersInterceptor's excludeParams or MethodFilterInterceptor's excludeMethods and includeMethods.
> It would also be good if the documentation included information and an example with a list of parameters. The current documentation (https://struts.apache.org/docs/chaining-interceptor.html) only says that the parameters are lists, but the example only has one parameter



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)