Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EEB63178A5 for ; Wed, 8 Apr 2015 05:08:13 +0000 (UTC) Received: (qmail 10460 invoked by uid 500); 8 Apr 2015 05:08:13 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 10418 invoked by uid 500); 8 Apr 2015 05:08:13 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 10255 invoked by uid 99); 8 Apr 2015 05:08:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2015 05:08:13 +0000 Date: Wed, 8 Apr 2015 05:08:13 +0000 (UTC) From: "Lukasz Lenart (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (WW-4433) ConventionUnknownHandler change breaks exception handling in interceptors. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484722#comment-14484722 ] Lukasz Lenart edited comment on WW-4433 at 4/8/15 5:07 AM: ----------------------------------------------------------- Just implement {{com.opensymphony.xwork2.UnknownHandler}} interface and throw {{NoSuchMethodException}} - that's all and now register the new handler like this http://struts.apache.org/docs/unknown-handlers.html BTW. you can help testing 2.3.23 http://markmail.org/thread/oqtssgeesejrobko was (Author: lukaszlenart): Just implement {{com.opensymphony.xwork2.UnknownHandler}} interface and throws {{NoSuchMethodException}} - that's all and now register the new handler like this http://struts.apache.org/docs/unknown-handlers.html BTW. you can help testing 2.3.23 http://markmail.org/thread/oqtssgeesejrobko > ConventionUnknownHandler change breaks exception handling in interceptors. > -------------------------------------------------------------------------- > > Key: WW-4433 > URL: https://issues.apache.org/jira/browse/WW-4433 > Project: Struts 2 > Issue Type: Bug > Components: Core Interceptors, Documentation, Plugin - Convention > Affects Versions: 2.3.20 > Reporter: Joseph Wolschon > Assignee: Lukasz Lenart > Priority: Minor > Fix For: 2.3.23 > > > Struts 2.3.20 appears to have caused a regression that prevents exceptions thrown from convention-plugin actions from reaching ExceptionMappingInterceptor. This breaks exception handling when using the convention-plugin. > To Reproduce: > * Generate a project struts2-archetype-convention archetype using 2.3.20 > * Throw exception in the action. With 2.3.20, a blank page is shown. > * Change to 2.3.16.3 and you will get the standard struts2 error page. > The breaking change appears to have been made in WW-4331. This causes error interceptor code to break (showing a blank page when exceptions are thrown) as DefaultActionInvocation does not catch an exception from the default UnknownHandler implementation execution, which would previously re-throw the original exception back up for the interceptors to catch. > Workaround: > We've created our own UnknownHandler implementation that just throws a new NoSuchMethodException, allowing DefaultActionInvocation to re-throw the original exception so that our error interceptor can again catch it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)