Mailing-List: contact issues-help@struts.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@struts.apache.org
Date: Thu, 5 Mar 2015 05:55:38 +0000 (UTC)
From: "Lukasz Lenart (JIRA)" <jira@apache.org>
To: issues@struts.apache.org
Message-ID: <JIRA.12772458.1423077091000.7003.1425534938263@Atlassian.JIRA>
In-Reply-To: <JIRA.12772458.1423077091000@Atlassian.JIRA>
References: <JIRA.12772458.1423077091000@Atlassian.JIRA>
 <JIRA.12772458.1423077091632@arcas>
Subject: [jira] [Commented] (WW-4457) FileUploadInterceptor uses injected
 pattern matcher
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/WW-4457?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1434820=
0#comment-14348200 ]=20

Lukasz Lenart commented on WW-4457:
-----------------------------------

but then it will always use the same matcher, I thought about adding anothe=
r extension point to allow use different implementations. The problem is th=
at an alias for such type was already registered in the internal DI so it m=
ust be represented by different type.

> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>
>                 Key: WW-4457
>                 URL: https://issues.apache.org/jira/browse/WW-4457
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>            Reporter: Aleksandr Mashchenko
>             Fix For: 2.3.x
>
>
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for che=
cking {{allowedTypes}}, which yields inconsistent behavior with different d=
efault pattern matchers. Some mime types which are working fine with {{Wild=
cardHelper}} are not working with the {{RegexPatternMatcher}}, because of t=
he special regex character presented in them (e.g. {{image/svg+xml}} - {{+}=
} is a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what =
pattern matcher is set as the default one. Or is there any point in injecti=
ng pattern matcher in file upload interceptor?
> Original report: [=E2=80=9CContent-Type not allowed=E2=80=9D while upload=
ing an SVG file, that is in the allowed whitelist|http://stackoverflow.com/=
q/28304692/1700321]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)