struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrea Ligios (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4457) FileUploadInterceptor uses injected pattern matcher
Date Mon, 16 Mar 2015 10:24:40 GMT

    [ https://issues.apache.org/jira/browse/WW-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363030#comment-14363030
] 

Andrea Ligios commented on WW-4457:
-----------------------------------

You're right, there was a caching problem on the server, my fault :/

I've now tried with 2.3.22 and the others on 2.3.16.3, and it doesn't even deploy, 
while with 2.3.22 and the others on 2.3.20, it deploys but CDI injection is failing and hence
I can't test the feature... 
I'll just assume it works, based on your try, because I've no time to create a full 2.3.22
SSCCE now. 
I'll be happy to retest this when 2.3.22 will be released, however. Thank you

> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>
>                 Key: WW-4457
>                 URL: https://issues.apache.org/jira/browse/WW-4457
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>            Reporter: Aleksandr Mashchenko
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.22
>
>
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher
is set as the default one. Or is there any point in injecting pattern matcher in file upload
interceptor?
> Original report: [“Content-Type not allowed” while uploading an SVG file, that is
in the allowed whitelist|http://stackoverflow.com/q/28304692/1700321]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message