struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4452) s:optiontransferselect javascript functions no longer work with negative integer keys
Date Thu, 19 Mar 2015 09:06:45 GMT

    [ https://issues.apache.org/jira/browse/WW-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368735#comment-14368735
] 

Hudson commented on WW-4452:
----------------------------

SUCCESS: Integrated in Struts-JDK6-master #904 (See [https://builds.apache.org/job/Struts-JDK6-master/904/])
WW-4452 Solves problem with using -1 as headerKey (lukaszlenart: rev 312a2717cf2f7094e42a83f7f05cb493c3d393c8)
* core/src/main/resources/org/apache/struts2/static/inputtransferselect.js
* core/src/main/resources/org/apache/struts2/static/optiontransferselect.js


> s:optiontransferselect javascript functions no longer work with negative integer keys
> -------------------------------------------------------------------------------------
>
>                 Key: WW-4452
>                 URL: https://issues.apache.org/jira/browse/WW-4452
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.20
>            Reporter: Brent N Atkinson
>            Assignee: Lukasz Lenart
>             Fix For: 2.3.22
>
>
> It appears that the change made to fix WW-4365 broke the javascript functions used to
implement onclick handlers for the s:optiontransferselect tag. 
> While attempting an upgrade to 2.3.20 from 2.3.16.3, all pages containing tags like the
following are broken (tests fail):
> {code}
> <s:optiontransferselect multiple="true" headerKey="-1" doubleHeaderKey="-1" multiple="true"
doubleMultiple="true" addAllToRightOnclick="selectAllOptionsExceptSome(document.getElementById('saveBuildDefinitionTemplate_selectedBuildDefinitionIds'),
'key', '-1');" />
> {code}
> Since the regular expression used to match the header keys now always attempts to match
on word boundary, the change introduced in WW-4365, it will not match negative numbers like
'-1'. This is likely to break a number of applications since [the struts 2 documentation for
optiontransferselect|https://cwiki.apache.org/confluence/display/WW/optiontransferselect]
suggests using '-1'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message