struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandr Mashchenko (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (WW-4457) FileUploadInterceptor uses injected pattern matcher
Date Wed, 04 Feb 2015 19:19:35 GMT

     [ https://issues.apache.org/jira/browse/WW-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aleksandr Mashchenko updated WW-4457:
-------------------------------------
    Description: 
Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).

IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher is
set as the default one. Or is there any point in injecting pattern matcher in file upload
interceptor?

Original report: [“Content-Type not allowed” while uploading an SVG file, that is in the
allowed whitelist|http://stackoverflow.com/q/28304692/1700321]

  was:
Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).

IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher is
set as the default one.
Or is there any point in injecting pattern matcher in file upload interceptor?

Original report: [“Content-Type not allowed” while uploading an SVG file, that is in the
allowed whitelist|http://stackoverflow.com/q/28304692/1700321]


> FileUploadInterceptor uses injected pattern matcher
> ---------------------------------------------------
>
>                 Key: WW-4457
>                 URL: https://issues.apache.org/jira/browse/WW-4457
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>            Reporter: Aleksandr Mashchenko
>
> Currently {{FileUploadInterceptor}} uses injected pattern matcher for checking {{allowedTypes}},
which yields inconsistent behavior with different default pattern matchers. Some mime types
which are working fine with {{WildcardHelper}} are not working with the {{RegexPatternMatcher}},
because of the special regex character presented in them (e.g. {{image/svg+xml}} - {{+}} is
a special character in regex).
> IMO file upload interceptor should use {{WildcardHelper}} no matter what pattern matcher
is set as the default one. Or is there any point in injecting pattern matcher in file upload
interceptor?
> Original report: [“Content-Type not allowed” while uploading an SVG file, that is
in the allowed whitelist|http://stackoverflow.com/q/28304692/1700321]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message