struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-4427) Converters no longer applied to values coming from the context
Date Tue, 09 Dec 2014 18:18:12 GMT

    [ https://issues.apache.org/jira/browse/WW-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239778#comment-14239778
] 

ASF GitHub Bot commented on WW-4427:
------------------------------------

Github user lukaszlenart commented on a diff in the pull request:

    https://github.com/apache/struts/pull/32#discussion_r21548312
  
    --- Diff: xwork-core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java ---
    @@ -351,6 +351,8 @@ private Object tryFindValue(String expr, Class asType) throws OgnlException
{
                 value = getValue(expr, asType);
                 if (value == null) {
                     value = findInContext(expr);
    +                final XWorkConverter conv = ((Container)getContext().get(ActionContext.CONTAINER)).getInstance(XWorkConverter.class);
    --- End diff --
    
    Why do you looking for Converter instead of `@Inject` it? You can inject it with
    ```java
        private XWorkConverter conv;
    
        @Inject
        public void setXWorkConverter(XWorkConverter conv) {
            this.conv = conv;
        }
    ```


> Converters no longer applied to values coming from the context
> --------------------------------------------------------------
>
>                 Key: WW-4427
>                 URL: https://issues.apache.org/jira/browse/WW-4427
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.3.16.1
>            Reporter: Przemek Bruski
>             Fix For: 2.3.x
>
>         Attachments: struts_patch.diff
>
>
> As a side effect of 4c45a9433bae5fe3fcad5acd95e4f437e548d075 , conversion is no longer
applied to values coming directly from OGNL context.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message