struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rene Gielen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (WW-4188) In struts tag lib, required attribute removed in latest version ie 2.3.15.1
Date Fri, 07 Nov 2014 09:46:34 GMT

    [ https://issues.apache.org/jira/browse/WW-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201838#comment-14201838
] 

Rene Gielen edited comment on WW-4188 at 11/7/14 9:45 AM:
----------------------------------------------------------

Once in a while I came to feel that we are doing something wrong with adding the * within
the template. That given, how about reverting to a solely CSS driven solution with the semantics
of HTML5 required attribute?
So setting tag attribute {code}required="true"{code} would render as
{code}
<label class="requiredLabel">...</label><input class="requiredField" required="required"
... />
{code}
Obviously, {code}required="required"{code} would be completely omitted if the tag attribute
is false.
For backward compatibility, we could recommend the following css based solution to re-gain
the "*" suffix behaviour:
http://stackoverflow.com/questions/2741312/using-css-to-insert-text


was (Author: rgielen):
Once in a while I came to feel that we are doing something wrong with adding the * within
the template. That given, how about reverting to a solely CSS driven solution with the semantics
of HTML5 required attribute?
So setting tag attribute {code}required="true"{code} would render as
{code}
<label class="requiredLabel">...</label><input class="requiredField" required="required"
... />
{code}
Obviously, {code}required="required"{code} would be completely omitted if the tag attribute
is false.
For backward compatibility, we could recommend the following solution in our default css to
add the "*" suffix behaviour:
http://stackoverflow.com/questions/2741312/using-css-to-insert-text

> In struts tag lib, required attribute removed in latest version ie 2.3.15.1
> ---------------------------------------------------------------------------
>
>                 Key: WW-4188
>                 URL: https://issues.apache.org/jira/browse/WW-4188
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.3.15.1
>         Environment: All
>            Reporter: mahendran
>            Assignee: Lukasz Lenart
>              Labels: struts-tags-required-attribute
>             Fix For: 2.5
>
>
> we are using struts 2.0.5 and 2.3.4.1 in our applications. And we decided to migrate
to 2.3.15.1 to get the security fixes.
> we use struts tags to render UI components and using 'required' attribute to get the
'*' along with the components.
> In the version 2.3.15.1, the attribute required is dropped, and we need to change to
requiredLabel to get the same effect, this increases migration&testing effort for a application
which has 1000+pages
> Hence we require a backward compatibility for 'required' attribute in struts tags.
> Also nowhere in the migration document this information is specified. This makes the
struts migration as block-box. Hence we require a proper migration document which should specify
what are all the changes required in the application to migrate the struts.
> But we managed to get the '*' in UI by replacing UIBean.class,AbsctactUITag.class and
struts.tld from 2.3.4.1 version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message