Return-Path: X-Original-To: apmail-struts-issues-archive@minotaur.apache.org Delivered-To: apmail-struts-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 597C411E19 for ; Thu, 24 Jul 2014 10:46:39 +0000 (UTC) Received: (qmail 16691 invoked by uid 500); 24 Jul 2014 10:46:38 -0000 Delivered-To: apmail-struts-issues-archive@struts.apache.org Received: (qmail 16598 invoked by uid 500); 24 Jul 2014 10:46:38 -0000 Mailing-List: contact issues-help@struts.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@struts.apache.org Delivered-To: mailing list issues@struts.apache.org Received: (qmail 16372 invoked by uid 99); 24 Jul 2014 10:46:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jul 2014 10:46:38 +0000 Date: Thu, 24 Jul 2014 10:46:38 +0000 (UTC) From: "Lorenzo Bernacchioni (JIRA)" To: issues@struts.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (WW-4378) ParametersInterceptor: param names exceeding paramNameMaxLength generates wrong message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WW-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorenzo Bernacchioni updated WW-4378: ------------------------------------- Description: When ParametersInterceptor receives a param with a name exceeding paramNameMaxLength (default 100 chars) it logs | Developer Notification (set struts.devMode to false to disable this message): Unexpected Exception caught setting 'aHR0cDovL3d3dy5qb2Jpc2pvYi5kZS9tJUMzJUJDbmNoZW4vd2Vya3N0dWRlbnQtd2lydHNjaGFmdHNpbmdlbmlldXJ3ZXNlbi9qb2Jz' on 'class java.lang.String: 100 while looking at the code it should log |Parameter ... is too long, allowed length is ... That's because there are two signatures of notifyDeveloper(), one hiding the other. I think it should be logged also in devMode was: When ParametersInterceptor receives a param with a name exceeding paramNameMaxLength (default 100 chars) it logs | Developer Notification (set struts.devMode to false to disable this message): Unexpected Exception caught setting 'aHR0cDovL3d3dy5qb2Jpc2pvYi5kZS9tJUMzJUJDbmNoZW4vd2Vya3N0dWRlbnQtd2lydHNjaGFmdHNpbmdlbmlldXJ3ZXNlbi9qb2Jz' on 'class java.lang.String: 100 while looking at the code it should log |Parameter [] is too long, allowed length is [] That's because there are two signatures of notifyDeveloper(), one hiding the other. I think it should be logged also in devMode > ParametersInterceptor: param names exceeding paramNameMaxLength generates wrong message > --------------------------------------------------------------------------------------- > > Key: WW-4378 > URL: https://issues.apache.org/jira/browse/WW-4378 > Project: Struts 2 > Issue Type: Bug > Components: Core Interceptors > Affects Versions: 2.3.16.3 > Reporter: Lorenzo Bernacchioni > Priority: Minor > Labels: logging, > > When ParametersInterceptor receives a param with a name exceeding paramNameMaxLength (default 100 chars) it logs > | Developer Notification (set struts.devMode to false to disable this message): > Unexpected Exception caught setting 'aHR0cDovL3d3dy5qb2Jpc2pvYi5kZS9tJUMzJUJDbmNoZW4vd2Vya3N0dWRlbnQtd2lydHNjaGFmdHNpbmdlbmlldXJ3ZXNlbi9qb2Jz' on 'class java.lang.String: 100 > while looking at the code it should log > |Parameter ... is too long, allowed length is ... > That's because there are two signatures of notifyDeveloper(), one hiding the other. > I think it should be logged also in devMode -- This message was sent by Atlassian JIRA (v6.2#6252)